Reset dependencies in unbuild

sokra · sokra · commit e829a5ed716a · 2017-12-12T17:01:14.000+01:00
Elsewise they are cleared in disconnect and module removing doesn't work correctly
diff --git a/lib/ContextModule.js b/lib/ContextModule.js
@@ -148,10 +148,6 @@ class ContextModule extends Module {
 		this.resolveDependencies(fs, this.options, (err, dependencies) => {
 			if(err) return callback(err);
 
-			// Reset children
-			this.dependencies.length = 0;
-			this.blocks.length = 0;
-
 			// abort if something failed
 			// this will create an empty context
 			if(!dependencies) {
diff --git a/lib/DelegatedModule.js b/lib/DelegatedModule.js
@@ -44,7 +44,6 @@ class DelegatedModule extends Module {
 		this.built = true;
 		this.buildMeta = Object.assign({}, this.delegateData.buildMeta);
 		this.buildInfo = {};
-		this.dependencies.length = 0;
 		this.addDependency(new DelegatedSourceDependency(this.sourceRequest));
 		this.addDependency(new DelegatedExportsDependency(this, this.delegateData.exports || true));
 		callback();
diff --git a/lib/Module.js b/lib/Module.js
@@ -289,6 +289,9 @@ class Module extends DependenciesBlock {
 	}
 
 	unbuild() {
+		this.dependencies.length = 0;
+		this.blocks.length = 0;
+		this.variables.length = 0;
 		this.buildMeta = undefined;
 		this.buildInfo = undefined;
 		this.disconnect();
diff --git a/lib/NormalModule.js b/lib/NormalModule.js
@@ -297,9 +297,6 @@ class NormalModule extends Module {
 		};
 
 		return this.doBuild(options, compilation, resolver, fs, (err) => {
-			this.dependencies.length = 0;
-			this.variables.length = 0;
-			this.blocks.length = 0;
 			this._cachedSource = undefined;
 			this._cachedSourceHash = undefined;
 
diff --git a/test/statsCases/separate-css-bundle/expected.txt b/test/statsCases/separate-css-bundle/expected.txt
@@ -1,12 +1,12 @@
-Hash: 2bead03ec2be56f57e2cf527918ae398de4766d7
+Hash: b584cac33dcb8d5e4aed9dcac735d940c7d4c5dc
 Child
-    Hash: 2bead03ec2be56f57e2c
+    Hash: b584cac33dcb8d5e4aed
     Time: Xms
                                    Asset      Size  Chunks             Chunk Names
-                 58840bf0b6b4228a57a9.js  2.74 KiB       0  [emitted]  main
+                 d6c1b876fc64139d8324.js  2.74 KiB       0  [emitted]  main
     c815cf440254d4f3bba4e7041db00a28.css  26 bytes       0  [emitted]  main
        [0] ./a/index.js 23 bytes {0} [built]
-       [1] ./a/file.css 41 bytes {0} [built]
+       [1] ./a/file.css 41 bytes [built]
        [2] (webpack)/node_modules/css-loader!./a/file.css 199 bytes [built]
        [3] (webpack)/node_modules/css-loader/lib/css-base.js 2.21 KiB [built]
        [4] (webpack)/node_modules/style-loader/lib/addStyles.js 8.5 KiB [built]
@@ -15,13 +15,13 @@ Child
            [0] (webpack)/node_modules/css-loader!./a/file.css 199 bytes {0} [built]
            [1] (webpack)/node_modules/css-loader/lib/css-base.js 2.21 KiB {0} [built]
 Child
-    Hash: f527918ae398de4766d7
+    Hash: 9dcac735d940c7d4c5dc
     Time: Xms
                                    Asset      Size  Chunks             Chunk Names
-                 58840bf0b6b4228a57a9.js  2.74 KiB       0  [emitted]  main
+                 d6c1b876fc64139d8324.js  2.74 KiB       0  [emitted]  main
     a3f385680aef7a9bb2a517699532cc34.css  28 bytes       0  [emitted]  main
        [0] ./b/index.js 23 bytes {0} [built]
-       [1] ./b/file.css 41 bytes {0} [built]
+       [1] ./b/file.css 41 bytes [built]
        [2] (webpack)/node_modules/css-loader!./b/file.css 201 bytes [built]
        [3] (webpack)/node_modules/css-loader/lib/css-base.js 2.21 KiB [built]
        [4] (webpack)/node_modules/style-loader/lib/addStyles.js 8.5 KiB [built]

Original file line number	Diff line number	Diff line change
`@@ -289,6 +289,9 @@ class Module extends DependenciesBlock {`
`289`	`289`	`}`
`290`	`290`
`291`	`291`	`unbuild() {`
	`292`	`+ this.dependencies.length = 0;`
	`293`	`+ this.blocks.length = 0;`
	`294`	`+ this.variables.length = 0;`
`292`	`295`	`this.buildMeta = undefined;`
`293`	`296`	`this.buildInfo = undefined;`
`294`	`297`	`this.disconnect();`