Avoid relying on Node’s internals

addaleax · addaleax · commit e4375f8833ee · 2018-01-27T22:10:36.000+01:00
`process.binding()` is not a public API, and should not be used. Luckily, Node recently introduced an API that does exactly what Webpack needs: https://nodejs.org/api/modules.html#modules_module_builtinmodules So use that instead and keep the old path as a fallback.
diff --git a/lib/node/NodeTargetPlugin.js b/lib/node/NodeTargetPlugin.js
@@ -6,9 +6,11 @@
 
 const ExternalsPlugin = require("../ExternalsPlugin");
 
+const builtins = require("module").builtinModules || Object.keys(process.binding("natives"));
+
 class NodeTargetPlugin {
 	apply(compiler) {
-		new ExternalsPlugin("commonjs", Object.keys(process.binding("natives"))).apply(compiler);
+		new ExternalsPlugin("commonjs", builtins).apply(compiler);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -6,9 +6,11 @@`
`6`	`6`
`7`	`7`	`const ExternalsPlugin = require("../ExternalsPlugin");`
`8`	`8`
	`9`	`+const builtins = require("module").builtinModules \|\| Object.keys(process.binding("natives"));`
	`10`	`+`
`9`	`11`	`class NodeTargetPlugin {`
`10`	`12`	`apply(compiler) {`
`11`		`- new ExternalsPlugin("commonjs", Object.keys(process.binding("natives"))).apply(compiler);`
	`13`	`+ new ExternalsPlugin("commonjs", builtins).apply(compiler);`
`12`	`14`	`}`
`13`	`15`	`}`
`14`	`16`