[fix] webpackOptionsSchema

Joe Bottigliero · Joe Bottigliero · commit e0d4501fabb7 · 2017-10-13T17:12:24.000-05:00
- Updates webpackOptionsSchema "stats" object to include "additionalProperties: false"
- Adds missing stats options
- Adds test for ensuring new stats options fail the schema check (if not included)
diff --git a/schemas/webpackOptionsSchema.json b/schemas/webpackOptionsSchema.json
@@ -975,6 +975,7 @@
       "anyOf": [
         {
           "type": "object",
+          "additionalProperties": false,
           "properties": {
             "context": {
               "type": "string",
@@ -997,6 +998,18 @@
               "type": "boolean",
               "description": "add assets information"
             },
+            "env": {
+              "type": "boolean",
+              "description": "add --env information"
+            },
+            "colors": {
+              "type": "boolean",
+              "description": "`webpack --colors` equivalent"
+            },
+            "maxModules": {
+              "type": "number",
+              "description": "Set the maximum number of modules to be shown"
+            },
             "chunks": {
               "type": "boolean",
               "description": "add chunk information"
diff --git a/test/Validation.test.js b/test/Validation.test.js
@@ -199,6 +199,20 @@ describe("Validation", () => {
 		message: [
 			" - configuration.context: The provided value \"baz\" is not an absolute path!",
 		]
+	}, {
+		name: "missing stats option",
+		config: {
+			entry: "foo.js",
+			stats: {
+				foobar: true
+			}
+		},
+		test(e) {
+			e.message.should.startWith("Invalid configuration object.");
+			e.message.split("\n").slice(1)[0].should.be.eql(
+				" - configuration.stats should be one of these:"
+			);
+		}
 	}];
 	testCases.forEach((testCase) => {
 		it("should fail validation for " + testCase.name, () => {
@@ -207,6 +221,12 @@ describe("Validation", () => {
 			} catch(e) {
 				if(!(e instanceof WebpackOptionsValidationError))
 					throw e;
+
+				if(testCase.test) {
+					testCase.test(e);
+					return;
+				}
+
 				e.message.should.startWith("Invalid configuration object.");
 				e.message.split("\n").slice(1).should.be.eql(testCase.message);
 				return;
