Merge pull request webpack#6055 from nikhilgaba/parserFix

sokra · web-flow · commit e03a227182eb · 2017-12-05T07:55:41.000+01:00
Improve Parser to recognize 'new Foo(...)' type expressions
diff --git a/lib/Parser.js b/lib/Parser.js
@@ -1047,6 +1047,14 @@ class Parser extends Tapable {
 	}
 
 	walkNewExpression(expression) {
+		const callee = this.evaluateExpression(expression.callee);
+		if(callee.isIdentifier()) {
+			const result = this.applyPluginsBailResult("new " + callee.identifier, expression);
+			if(result === true) {
+				return;
+			}
+		}
+
 		this.walkExpression(expression.callee);
 		if(expression.arguments)
 			this.walkExpressions(expression.arguments);
diff --git a/test/Parser.unittest.js b/test/Parser.unittest.js
@@ -191,6 +191,13 @@ describe("Parser", () => {
 				ijksub: ["test"]
 			}
 		],
+		"new Foo(...)": [
+			function() {
+				new xyz("membertest");
+			}, {
+				xyz: ["membertest"]
+			}
+		],
 	};
 
 	Object.keys(testCases).forEach((name) => {
@@ -237,6 +244,11 @@ describe("Parser", () => {
 				testParser.state.expressions.push(expr.name);
 				return true;
 			});
+			testParser.plugin("new xyz", (expr) => {
+				if(!testParser.state.xyz) testParser.state.xyz = [];
+				testParser.state.xyz.push(testParser.parseString(expr.arguments[0]));
+				return true;
+			});
 			const actual = testParser.parse(source);
 			should.strictEqual(typeof actual, "object");
 			actual.should.be.eql(state);
