Merge pull request webpack#4815 from webpack/bugfix/extract-async-initial

sokra · web-flow · commit cd1cd29fba46 · 2017-05-04T11:41:43.000+02:00
CommonsChunkPlugin in async mode doesn't select initial chunks
diff --git a/lib/optimize/CommonsChunkPlugin.js b/lib/optimize/CommonsChunkPlugin.js
@@ -190,7 +190,7 @@ You can however specify the name of the async chunk by passing the desired strin
 
 		// we dont have named chunks specified, so we just take all of them
 		if(asyncOrNoSelectedChunk) {
-			return allChunks;
+			return allChunks.filter(chunk => !chunk.isInitial());
 		}
 
 		/**
diff --git a/test/configCases/commons-chunk-plugin/extract-async-from-entry/index.js b/test/configCases/commons-chunk-plugin/extract-async-from-entry/index.js
@@ -0,0 +1,4 @@
+require("should");
+
+it("should run successful", function() {
+});
diff --git a/test/configCases/commons-chunk-plugin/extract-async-from-entry/test.config.js b/test/configCases/commons-chunk-plugin/extract-async-from-entry/test.config.js
@@ -0,0 +1,8 @@
+module.exports = {
+	findBundle: function(i, options) {
+		return [
+			"./manifest.js",
+			"./main.js"
+		];
+	}
+};
diff --git a/test/configCases/commons-chunk-plugin/extract-async-from-entry/webpack.config.js b/test/configCases/commons-chunk-plugin/extract-async-from-entry/webpack.config.js
@@ -0,0 +1,21 @@
+var CommonsChunkPlugin = require("../../../../lib/optimize/CommonsChunkPlugin");
+module.exports = {
+	entry: {
+		main: "./index",
+		second: "./index"
+	},
+	target: "web",
+	output: {
+		filename: "[name].js"
+	},
+	plugins: [
+		new CommonsChunkPlugin({
+			minChunks: Infinity,
+			name: "manifest"
+		}),
+		new CommonsChunkPlugin({
+			async: "async",
+			minChunks: 2
+		})
+	]
+};

Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,7 @@ You can however specify the name of the async chunk by passing the desired strin`
`190`	`190`
`191`	`191`	`// we dont have named chunks specified, so we just take all of them`
`192`	`192`	`if(asyncOrNoSelectedChunk) {`
`193`		`- return allChunks;`
	`193`	`+ return allChunks.filter(chunk => !chunk.isInitial());`
`194`	`194`	`}`
`195`	`195`
`196`	`196`	`/**`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +require("should");
++
 +it("should run successful", function() {
 +});