fix(): fix outstanding typewarnings from typeof in Template

TheLarkInn · TheLarkInn · commit c7f3c588e3d7 · 2018-04-30T23:00:22.000-05:00
diff --git a/lib/Module.js b/lib/Module.js
@@ -12,7 +12,6 @@ const SortableSet = require("./util/SortableSet");
 const Template = require("./Template");
 
 /** @typedef {typeof import("./Chunk")} Chunk */
-
 /** @typedef {typeof import("./RequestShortener")} RequestShortener */
 
 const EMPTY_RESOLVE_OPTIONS = {};
@@ -101,6 +100,9 @@ class Module extends DependenciesBlock {
 
 		/** @type {boolean} */
 		this.useSourceMap = false;
+
+		// info from build
+		this._source = null;
 	}
 
 	get exportsArgument() {
diff --git a/lib/Template.js b/lib/Template.js
@@ -2,12 +2,13 @@
 	MIT License http://www.opensource.org/licenses/mit-license.php
 	Author Tobias Koppers @sokra
 */
-/** @typedef {typeof import("./Module")} Module */
-/** @typedef {typeof import("./Chunk")} Chunk */
-/** @typedef {typeof import("./ModuleTemplate")} ModuleTemplate */
+/** @typedef {import("./Module")} Module */
+/** @typedef {import("./Chunk")} Chunk */
+/** @typedef {import("./ModuleTemplate")} ModuleTemplate */
 /** @typedef {import("webpack-sources").ConcatSource} ConcatSource */
 
 const { ConcatSource } = require("webpack-sources");
+const HotUpdateChunk = require("./HotUpdateChunk");
 
 const START_LOWERCASE_ALPHABET_CODE = "a".charCodeAt(0);
 const START_UPPERCASE_ALPHABET_CODE = "A".charCodeAt(0);
@@ -204,13 +205,11 @@ class Template {
 		return arrayOverhead < objectOverhead ? [minId, maxId] : false;
 	}
 
-	//TODO: replace any for Chunk and ModuleTemplate types instead.
-	//https://github.com/Microsoft/TypeScript/issues/23375
 	/**
 	 *
-	 * @param {any} chunk chunk whose modules will be rendered
+	 * @param {Chunk} chunk chunk whose modules will be rendered
 	 * @param {ModuleFilterPredicate} filterFn function used to filter modules from chunk to render
-	 * @param {any} moduleTemplate ModuleTemplate instance used to render modules
+	 * @param {ModuleTemplate} moduleTemplate ModuleTemplate instance used to render modules
 	 * @param {any | any[]} dependencyTemplates templates needed for each module to render dependencies
 	 * @param {string=} prefix applying prefix strings
 	 * @return {ConcatSource} rendered chunk modules in a Source object
@@ -225,7 +224,9 @@ class Template {
 		if (!prefix) prefix = "";
 		var source = new ConcatSource();
 		const modules = chunk.getModules().filter(filterFn);
-		var removedModules = chunk.removedModules;
+		if (chunk instanceof HotUpdateChunk) {
+			var removedModules = chunk.removedModules;
+		}
 		if (
 			modules.length === 0 &&
 			(!removedModules || removedModules.length === 0)
