Set null prototype on perf-critical classes

ooflorent · ooflorent · commit c4d64ab42494 · 2018-06-06T19:48:38.000+02:00
diff --git a/lib/BasicEvaluatedExpression.js b/lib/BasicEvaluatedExpression.js
@@ -208,4 +208,6 @@ class BasicEvaluatedExpression {
 	}
 }
 
+Object.setPrototypeOf(BasicEvaluatedExpression.prototype, null);
+
 module.exports = BasicEvaluatedExpression;
diff --git a/lib/Chunk.js b/lib/Chunk.js
@@ -694,6 +694,8 @@ class Chunk {
 	}
 }
 
+Object.setPrototypeOf(Chunk.prototype, null);
+
 // TODO remove in webpack 5
 Object.defineProperty(Chunk.prototype, "forEachModule", {
 	configurable: false,
diff --git a/lib/ChunkGroup.js b/lib/ChunkGroup.js
@@ -470,4 +470,6 @@ class ChunkGroup {
 	}
 }
 
+Object.setPrototypeOf(ChunkGroup.prototype, null);
+
 module.exports = ChunkGroup;
diff --git a/lib/DependenciesBlock.js b/lib/DependenciesBlock.js
@@ -58,7 +58,9 @@ class DependenciesBlock {
 	}
 
 	unseal() {
-		for (const block of this.blocks) block.unseal();
+		for (const block of this.blocks) {
+			block.unseal();
+		}
 	}
 
 	hasDependencies(filter) {
@@ -82,8 +84,12 @@ class DependenciesBlock {
 	}
 
 	sortItems() {
-		for (const block of this.blocks) block.sortItems();
+		for (const block of this.blocks) {
+			block.sortItems();
+		}
 	}
 }
 
+Object.setPrototypeOf(DependenciesBlock.prototype, null);
+
 module.exports = DependenciesBlock;
diff --git a/lib/DependenciesBlockVariable.js b/lib/DependenciesBlockVariable.js
@@ -49,4 +49,6 @@ class DependenciesBlockVariable {
 	}
 }
 
+Object.setPrototypeOf(DependenciesBlockVariable.prototype, null);
+
 module.exports = DependenciesBlockVariable;
diff --git a/lib/Dependency.js b/lib/Dependency.js
@@ -15,6 +15,10 @@ class Dependency {
 		this.loc = undefined;
 	}
 
+	static compare(a, b) {
+		return compareLocations(a.loc, b.loc);
+	}
+
 	getResourceIdentifier() {
 		return null;
 	}
@@ -46,6 +50,7 @@ class Dependency {
 		this.module = null;
 	}
 }
-Dependency.compare = (a, b) => compareLocations(a.loc, b.loc);
+
+Object.setPrototypeOf(Dependency.prototype, null);
 
 module.exports = Dependency;

Original file line number	Diff line number	Diff line change
`@@ -208,4 +208,6 @@ class BasicEvaluatedExpression {`
`208`	`208`	`}`
`209`	`209`	`}`
`210`	`210`
	`211`	`+Object.setPrototypeOf(BasicEvaluatedExpression.prototype, null);`
	`212`	`+`
`211`	`213`	`module.exports = BasicEvaluatedExpression;`
Original file line number	Diff line number	Diff line change
`@@ -694,6 +694,8 @@ class Chunk {`
`694`	`694`	`}`
`695`	`695`	`}`
`696`	`696`
	`697`	`+Object.setPrototypeOf(Chunk.prototype, null);`
	`698`	`+`
`697`	`699`	`// TODO remove in webpack 5`
`698`	`700`	`Object.defineProperty(Chunk.prototype, "forEachModule", {`
`699`	`701`	`configurable: false,`
Original file line number	Diff line number	Diff line change
`@@ -470,4 +470,6 @@ class ChunkGroup {`
`470`	`470`	`}`
`471`	`471`	`}`
`472`	`472`
	`473`	`+Object.setPrototypeOf(ChunkGroup.prototype, null);`
	`474`	`+`
`473`	`475`	`module.exports = ChunkGroup;`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,9 @@ class DependenciesBlock {`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`unseal() {`
`61`		`- for (const block of this.blocks) block.unseal();`
	`61`	`+ for (const block of this.blocks) {`
	`62`	`+ block.unseal();`
	`63`	`+ }`
`62`	`64`	`}`
`63`	`65`
`64`	`66`	`hasDependencies(filter) {`
`@@ -82,8 +84,12 @@ class DependenciesBlock {`
`82`	`84`	`}`
`83`	`85`
`84`	`86`	`sortItems() {`
`85`		`- for (const block of this.blocks) block.sortItems();`
	`87`	`+ for (const block of this.blocks) {`
	`88`	`+ block.sortItems();`
	`89`	`+ }`
`86`	`90`	`}`
`87`	`91`	`}`
`88`	`92`
	`93`	`+Object.setPrototypeOf(DependenciesBlock.prototype, null);`
	`94`	`+`
`89`	`95`	`module.exports = DependenciesBlock;`
Original file line number	Diff line number	Diff line change
`@@ -49,4 +49,6 @@ class DependenciesBlockVariable {`
`49`	`49`	`}`
`50`	`50`	`}`
`51`	`51`
	`52`	`+Object.setPrototypeOf(DependenciesBlockVariable.prototype, null);`
	`53`	`+`
`52`	`54`	`module.exports = DependenciesBlockVariable;`
Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,10 @@ class Dependency {`
`15`	`15`	`this.loc = undefined;`
`16`	`16`	`}`
`17`	`17`
	`18`	`+ static compare(a, b) {`
	`19`	`+ return compareLocations(a.loc, b.loc);`
	`20`	`+ }`
	`21`	`+`
`18`	`22`	`getResourceIdentifier() {`
`19`	`23`	`return null;`
`20`	`24`	`}`
`@@ -46,6 +50,7 @@ class Dependency {`
`46`	`50`	`this.module = null;`
`47`	`51`	`}`
`48`	`52`	`}`
`49`		`-Dependency.compare = (a, b) => compareLocations(a.loc, b.loc);`
	`53`	`+`
	`54`	`+Object.setPrototypeOf(Dependency.prototype, null);`
`50`	`55`
`51`	`56`	`module.exports = Dependency;`