Invalidate concatenated module on dep change

kpdecker · kpdecker · commit bd7652823c5c · 2018-04-28T15:32:28.000-05:00
When the moduleSet for a given concatenated module changed, the source for the embedded modules would not necessarily, which lead to caching mismatch between the source and the modulesWithInfo structure. Fixes webpack#6168
diff --git a/lib/optimize/ConcatenatedModule.js b/lib/optimize/ConcatenatedModule.js
@@ -576,9 +576,12 @@ class ConcatenatedModule extends Module {
 				moduleToInfoMap
 			)
 		);
+
+		// Must use full identifier in our cache here to ensure that the source
+		// is updated should our dependencies list change.
 		innerDependencyTemplates.set(
 			"hash",
-			innerDependencyTemplates.get("hash") + this.rootModule.identifier()
+			innerDependencyTemplates.get("hash") + this.identifier()
 		);
 
 		// Generate source code and analyse scopes
