fix: ReferenceError: onScriptComplete is not defined when using HMR on Firefox 45

chris-czopp · chris-czopp · commit bbb9f38b719f · 2018-05-11T16:22:27.000+01:00
diff --git a/lib/web/JsonpMainTemplatePlugin.js b/lib/web/JsonpMainTemplatePlugin.js
@@ -173,7 +173,6 @@ class JsonpMainTemplatePlugin {
 						"onScriptComplete({ type: 'timeout', target: script });"
 					]),
 					`}, ${chunkLoadTimeout});`,
-					"script.onerror = script.onload = onScriptComplete;",
 					"function onScriptComplete(event) {",
 					Template.indent([
 						"// avoid mem leaks in IE.",
@@ -196,7 +195,8 @@ class JsonpMainTemplatePlugin {
 						]),
 						"}"
 					]),
-					"};"
+					"};",
+          "script.onerror = script.onload = onScriptComplete;"
 				]);
 			}
 		);
