Merge pull request webpack#7059 from bastimeyer/bugfix/loaderplugin-recursive

sokra · web-flow · commit babc8a442569 · 2018-04-17T09:24:32.000+02:00
Fix LoaderPlugin not resolving recursively
diff --git a/lib/dependencies/LoaderPlugin.js b/lib/dependencies/LoaderPlugin.js
@@ -47,7 +47,7 @@ class LoaderPlugin {
 							],
 							true,
 							"lm",
-							false,
+							true,
 							err => {
 								compilation.semaphore.acquire(() => {
 									if (err) return callback(err);
diff --git a/test/cases/loaders/issue-4959/a.js b/test/cases/loaders/issue-4959/a.js
@@ -0,0 +1 @@
+module.exports = "a";
diff --git a/test/cases/loaders/issue-4959/b.js b/test/cases/loaders/issue-4959/b.js
@@ -0,0 +1 @@
+module.exports = require("c");
diff --git a/test/cases/loaders/issue-4959/c.js b/test/cases/loaders/issue-4959/c.js
@@ -0,0 +1 @@
+module.exports = "c";
diff --git a/test/cases/loaders/issue-4959/index.js b/test/cases/loaders/issue-4959/index.js
@@ -0,0 +1,3 @@
+it("should resolve module dependencies recursively", function() {
+	require("!./loaders/index!a").should.be.eql("c");
+});
diff --git a/test/cases/loaders/issue-4959/loaders/index.js b/test/cases/loaders/issue-4959/loaders/index.js
@@ -0,0 +1,9 @@
+module.exports = function() {
+	var callback = this.async();
+	this.loadModule("b", function(error) {
+		if (error) {
+			return callback(error);
+		}
+		callback(null, "module.exports = require('b');");
+	});
+};
diff --git a/test/cases/loaders/issue-4959/package.json b/test/cases/loaders/issue-4959/package.json
@@ -0,0 +1,7 @@
+{
+	"browser": {
+		"a": "./a.js",
+		"b": "./b.js",
+		"c": "./c.js"
+	}
+}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+it("should resolve module dependencies recursively", function() {`
	`2`	`+ require("!./loaders/index!a").should.be.eql("c");`
	`3`	`+});`