shouldnt exclude ? when parsing querystring

Travmatth · Travmatth · commit a82aeedac41d · 2017-04-17T15:58:04.000-04:00
diff --git a/lib/BannerPlugin.js b/lib/BannerPlugin.js
@@ -43,7 +43,7 @@ class BannerPlugin {
 							const querySplit = filename.indexOf("?");
 
 							if(querySplit >= 0) {
-								query = filename.substr(querySplit + 1);
+								query = filename.substr(querySplit);
 								filename = filename.substr(0, querySplit);
 							}
 
diff --git a/test/configCases/plugins/banner-plugin-hashing/index.js b/test/configCases/plugins/banner-plugin-hashing/index.js
@@ -34,7 +34,7 @@ it("should interpolate basename in chunk banner", () => {
 });
 
 it("should interpolate query in chunk banner", () => {
-		banner["query"].should.equal("value");
+		banner["query"].should.equal("?value");
 });
 
 it("should parse entry into basename", () => {

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ class BannerPlugin {`
`43`	`43`	`const querySplit = filename.indexOf("?");`
`44`	`44`
`45`	`45`	`if(querySplit >= 0) {`
`46`		`- query = filename.substr(querySplit + 1);`
	`46`	`+ query = filename.substr(querySplit);`
`47`	`47`	`filename = filename.substr(0, querySplit);`
`48`	`48`	`}`
`49`	`49`