update WebpackError based on review

shellscape · shellscape · commit a4114f96223e · 2018-03-21T21:28:58.000-04:00
diff --git a/lib/WebpackError.js b/lib/WebpackError.js
@@ -6,16 +6,19 @@
 
 const createHash = require("./util/createHash");
 
-const hash = Symbol();
-const meta = Symbol();
+const hash = Symbol("hash");
+const meta = Symbol("meta");
 
 module.exports = class WebpackError extends Error {
 	constructor(
 		message,
-		line = 0,
-		column = 0,
-		columnEnd = 0,
-		category = "error"
+		options = Object.create({
+			category: "error",
+			// NOTE: went with a more semantic structure here, even though it
+			// deviates from other similar structures in webpack
+			column: { end: 0, start: 0 },
+			line: { end: 0, start: 0 }
+		})
 	) {
 		// TODO: enable message assertion during construction in a commit to follow
 		// if (!message) {
@@ -29,11 +32,10 @@ module.exports = class WebpackError extends Error {
 		super(message);
 
 		this[hash] = createHash("md4");
-		this[meta] = {};
-		this.category = category;
-		this.column = column;
-		this.columnEnd = columnEnd;
-		this.line = line;
+		this[meta] = Object.create(null);
+		this.category = options.category;
+		this.column = options.column;
+		this.line = options.line;
 
 		// TODO: enable abstract protection at a commit to follow
 		// if (this.constructor === WebpackError) {
@@ -51,7 +53,7 @@ module.exports = class WebpackError extends Error {
 		// use process.stdout to assert the message will be displayed in
 		// environments where console has been proxied. this mimics node's
 		// util.deprecate method.
-		process.stdout.write(`DeprecationWarning: ${message}\n${stack}\n`);
+		process.emitWarning(`DeprecationWarning: ${message}\n${stack}\n`);
 	}
 
 	get id() {
