Merge pull request webpack#7223 from webpack/bugfix/split-chunks-no-name

sokra · web-flow · commit 9c4c9deb7522 · 2018-05-07T13:33:18.000+02:00
fix bug where splitChunks doesn't work
diff --git a/lib/optimize/SplitChunksPlugin.js b/lib/optimize/SplitChunksPlugin.js
@@ -521,7 +521,8 @@ module.exports = class SplitChunksPlugin {
 						// Walk through all chunks
 						for (const chunk of item.chunks.keys()) {
 							// skip if we address ourself
-							if (chunk.name === chunkName || chunk === newChunk) continue;
+							if ((chunkName && chunk.name === chunkName) || chunk === newChunk)
+								continue;
 							// respect max requests when not enforced
 							const maxRequests = chunk.isOnlyInitial()
 								? item.cacheGroup.maxInitialRequests
diff --git a/test/__snapshots__/StatsTestCases.test.js.snap b/test/__snapshots__/StatsTestCases.test.js.snap
@@ -126,16 +126,16 @@ chunk   {11} fcdf398c8972e4dcf788.js 1.76 KiB <{10}> ={2}= ={6}= [rendered] [rec
 
 exports[`StatsTestCases should print correct stats for async-commons-chunk 1`] = `
 "Entrypoint main = main.js
-chunk    {0} 0.js 21 bytes <{3}> [rendered] reused as split chunk (cache group: default)
+chunk    {0} 0.js 21 bytes <{3}> ={1}= ={2}= [rendered] reused as split chunk (cache group: default)
+    > [3] ./index.js 17:1-21:3
     > [3] ./index.js 2:1-5:3
- [0] ./a.js 21 bytes {0} {1} {2} [built]
-chunk    {1} 1.js 42 bytes <{3}> [rendered]
     > ./a ./b [3] ./index.js 9:1-13:3
- [0] ./a.js 21 bytes {0} {1} {2} [built]
+ [0] ./a.js 21 bytes {0} [built]
+chunk    {1} 1.js 21 bytes <{3}> ={0}= [rendered]
+    > ./a ./b [3] ./index.js 9:1-13:3
  [1] ./b.js 21 bytes {1} [built]
-chunk    {2} 2.js 42 bytes <{3}> [rendered]
+chunk    {2} 2.js 21 bytes <{3}> ={0}= [rendered]
     > [3] ./index.js 17:1-21:3
- [0] ./a.js 21 bytes {0} {1} {2} [built]
  [2] ./c.js 21 bytes {2} [built]
 chunk    {3} main.js (main) 515 bytes >{0}< >{1}< >{2}< [entry] [rendered]
     > ./ main
