explicitly call new Stats with compilation

timse · timse · commit 8165164d3e50 · 2017-04-06T21:40:58.000+10:00
instead of having compilation.getStats returning a new instance of `Stats(this)`
diff --git a/lib/Compilation.js b/lib/Compilation.js
@@ -14,7 +14,6 @@ const ModuleDependencyError = require("./ModuleDependencyError");
 const Module = require("./Module");
 const Chunk = require("./Chunk");
 const Entrypoint = require("./Entrypoint");
-const Stats = require("./Stats");
 const MainTemplate = require("./MainTemplate");
 const ChunkTemplate = require("./ChunkTemplate");
 const HotUpdateChunkTemplate = require("./HotUpdateChunkTemplate");
@@ -1214,10 +1213,6 @@ class Compilation extends Tapable {
 		return this.mainTemplate.applyPluginsWaterfall("asset-path", filename, data);
 	}
 
-	getStats() {
-		return new Stats(this);
-	}
-
 	createChildCompiler(name, outputOptions) {
 		return this.compiler.createChildCompiler(this, name, outputOptions);
 	}
diff --git a/lib/Compiler.js b/lib/Compiler.js
@@ -6,15 +6,14 @@ var path = require("path");
 var Tapable = require("tapable");
 
 var Compilation = require("./Compilation");
-
+var Stats = require("./Stats");
 var NormalModuleFactory = require("./NormalModuleFactory");
 var ContextModuleFactory = require("./ContextModuleFactory");
 
 function Watching(compiler, watchOptions, handler) {
 	this.startTime = null;
 	this.invalid = false;
 	this.error = null;
-	this.stats = null;
 	this.handler = handler;
 	this.closed = false;
 	if(typeof watchOptions === "number") {
@@ -61,7 +60,7 @@ Watching.prototype._go = function() {
 					if(compilation.applyPluginsBailResult("need-additional-pass")) {
 						compilation.needAdditionalPass = true;
 
-						var stats = compilation.getStats();
+						var stats = new Stats(compilation);
 						stats.startTime = self.startTime;
 						stats.endTime = new Date().getTime();
 						self.compiler.applyPlugins("done", stats);
@@ -83,7 +82,7 @@ Watching.prototype._done = function(err, compilation) {
 	this.running = false;
 	if(this.invalid) return this._go();
 	this.error = err || null;
-	this.stats = compilation ? compilation.getStats() : null;
+	this.stats = compilation ? new Stats(compilation) : null;
 	if(this.stats) {
 		this.stats.startTime = this.startTime;
 		this.stats.endTime = new Date().getTime();
@@ -232,7 +231,7 @@ Compiler.prototype.run = function(callback) {
 					if(err) return callback(err);
 
 					if(self.applyPluginsBailResult("should-emit", compilation) === false) {
-						var stats = compilation.getStats();
+						var stats = new Stats(compilation);
 						stats.startTime = startTime;
 						stats.endTime = new Date().getTime();
 						self.applyPlugins("done", stats);
@@ -245,7 +244,7 @@ Compiler.prototype.run = function(callback) {
 						if(compilation.applyPluginsBailResult("need-additional-pass")) {
 							compilation.needAdditionalPass = true;
 
-							var stats = compilation.getStats();
+							var stats = new Stats(compilation);
 							stats.startTime = startTime;
 							stats.endTime = new Date().getTime();
 							self.applyPlugins("done", stats);
@@ -260,7 +259,7 @@ Compiler.prototype.run = function(callback) {
 						self.emitRecords(function(err) {
 							if(err) return callback(err);
 
-							var stats = compilation.getStats();
+							var stats = new Stats(compilation);
 							stats.startTime = startTime;
 							stats.endTime = new Date().getTime();
 							self.applyPlugins("done", stats);
