Merge pull request webpack#6335 from Connormiha/banner-plugin-optimize

sokra · web-flow · commit 80ed1c4b91fc · 2018-01-19T09:01:50.000+01:00
Minor optimize banner plugin
diff --git a/lib/BannerPlugin.js b/lib/BannerPlugin.js
@@ -47,10 +47,12 @@ class BannerPlugin {
 								filename = filename.substr(0, querySplit);
 							}
 
-							if(filename.indexOf("/") < 0) {
+							const lastSlashIndex = filename.lastIndexOf("/");
+
+							if(lastSlashIndex === -1) {
 								basename = filename;
 							} else {
-								basename = filename.substr(filename.lastIndexOf("/") + 1);
+								basename = filename.substr(lastSlashIndex + 1);
 							}
 
 							const comment = compilation.getPath(banner, {

Original file line number	Diff line number	Diff line change
`@@ -47,10 +47,12 @@ class BannerPlugin {`
`47`	`47`	`filename = filename.substr(0, querySplit);`
`48`	`48`	`}`
`49`	`49`
`50`		`- if(filename.indexOf("/") < 0) {`
	`50`	`+ const lastSlashIndex = filename.lastIndexOf("/");`
	`51`	`+`
	`52`	`+ if(lastSlashIndex === -1) {`
`51`	`53`	`basename = filename;`
`52`	`54`	`} else {`
`53`		`- basename = filename.substr(filename.lastIndexOf("/") + 1);`
	`55`	`+ basename = filename.substr(lastSlashIndex + 1);`
`54`	`56`	`}`
`55`	`57`
`56`	`58`	`const comment = compilation.getPath(banner, {`