Skip to content

Commit 6bb2436

Browse files
committed
Merge branch 'master' into next
# Conflicts: # lib/JsonpMainTemplatePlugin.js # test/WebWorkerMainTemplatePlugin.unittest.js # yarn.lock
2 parents 9870165 + 801a253 commit 6bb2436

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

lib/web/JsonpMainTemplatePlugin.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,8 +241,8 @@ class JsonpMainTemplatePlugin {
241241
function hotDisposeChunk(chunkId) {
242242
delete installedChunks[chunkId];
243243
}
244-
var parentHotUpdateCallback = this[${JSON.stringify(hotUpdateFunction)}];
245-
this[${JSON.stringify(hotUpdateFunction)}] = ${runtimeSource}`;
244+
var parentHotUpdateCallback = window[${JSON.stringify(hotUpdateFunction)}];
245+
window[${JSON.stringify(hotUpdateFunction)}] = ${runtimeSource}`;
246246
});
247247
mainTemplate.plugin("hash", hash => {
248248
hash.update("jsonp");

lib/webworker/WebWorkerMainTemplatePlugin.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ class WebWorkerMainTemplatePlugin {
8181
});
8282

8383
return source + "\n" +
84-
`var parentHotUpdateCallback = this[${JSON.stringify(hotUpdateFunction)}];\n` +
85-
`this[${JSON.stringify(hotUpdateFunction)}] = ` +
84+
`var parentHotUpdateCallback = self[${JSON.stringify(hotUpdateFunction)}];\n` +
85+
`self[${JSON.stringify(hotUpdateFunction)}] = ` +
8686
Template.getFunctionContent(require("./WebWorkerMainTemplate.runtime.js"))
8787
.replace(/\/\/\$semicolon/g, ";")
8888
.replace(/\$require\$/g, mainTemplate.requireFn)

yarn.lock

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3811,10 +3811,14 @@ source-map@0.4.x, source-map@^0.4.4:
38113811
dependencies:
38123812
amdefine ">=0.0.4"
38133813

3814-
source-map@^0.5.3, source-map@^0.5.6:
3814+
source-map@^0.5.3:
38153815
version "0.5.7"
38163816
resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.5.7.tgz#8a039d2d1021d22d1ea14c80d8ea468ba2ef3fcc"
38173817

3818+
source-map@^0.5.6, source-map@~0.5.1:
3819+
version "0.5.6"
3820+
resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.5.6.tgz#75ce38f52bf0733c5a7f0c118d81334a2bb5f412"
3821+
38183822
source-map@^0.6.1, source-map@~0.6.1:
38193823
version "0.6.1"
38203824
resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.6.1.tgz#74722af32e9614e9c287a8d0bbde48b5e2f1a263"
@@ -3831,10 +3835,6 @@ source-map@~0.2.0:
38313835
dependencies:
38323836
amdefine ">=0.0.4"
38333837

3834-
source-map@~0.5.1:
3835-
version "0.5.6"
3836-
resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.5.6.tgz#75ce38f52bf0733c5a7f0c118d81334a2bb5f412"
3837-
38383838
spdx-correct@~1.0.0:
38393839
version "1.0.2"
38403840
resolved "https://registry.yarnpkg.com/spdx-correct/-/spdx-correct-1.0.2.tgz#4b3073d933ff51f3912f03ac5519498a4150db40"
@@ -4270,8 +4270,8 @@ webpack-dev-middleware@^1.9.0:
42704270
time-stamp "^2.0.0"
42714271

42724272
webpack-sources@^1.0.1:
4273-
version "1.0.2"
4274-
resolved "https://registry.yarnpkg.com/webpack-sources/-/webpack-sources-1.0.2.tgz#d0148ec083b3b5ccef1035a6b3ec16442983b27a"
4273+
version "1.1.0"
4274+
resolved "https://registry.yarnpkg.com/webpack-sources/-/webpack-sources-1.1.0.tgz#a101ebae59d6507354d71d8013950a3a8b7a5a54"
42754275
dependencies:
42764276
source-list-map "^2.0.0"
42774277
source-map "~0.6.1"

0 commit comments

Comments
 (0)