declare types for chrome-trace-event

sokra · sokra · commit 5f0a99e93bf7 · 2018-04-12T11:42:41.000+02:00
diff --git a/declarations.d.ts b/declarations.d.ts
@@ -8,6 +8,29 @@ declare namespace NodeJS {
 	}
 }
 
+// There are no typings for chrome-trace-event
+declare module 'chrome-trace-event' {
+	interface Event {
+		name: string
+		id?: number
+		cat: string[]
+		args?: Object
+	}
+
+	export class Tracer {
+		constructor(options: {
+			noStream: boolean
+		})
+		pipe(stream: NodeJS.WritableStream) : void
+		instantEvent(event: Event) : void
+		counter: number
+		trace: {
+			begin(event: Event) : void
+			end(event: Event) : void
+		}
+	}
+}
+
 /**
  * Global variable declarations
  * @todo Once this issue is resolved, remove these globals and add JSDoc onsite instead
diff --git a/lib/debug/ProfilingPlugin.js b/lib/debug/ProfilingPlugin.js
@@ -324,10 +324,10 @@ const makeInterceptorFor = (instance, tracer) => hookName => ({
 
 /**
  * @param {string} hookName Name of the hook to profile.
- * @param {{counter: number, trace: *, profiler: *}} tracer Instance of tracer.
+ * @param {Tracer} tracer Instance of tracer.
  * @param {object} options Options for the profiled fn.
- * @param {string=} options.name Plugin name
- * @param {string=} options.type Plugin type (sync | async | promise)
+ * @param {string} options.name Plugin name
+ * @param {string} options.type Plugin type (sync | async | promise)
  * @param {PluginFunction} options.fn Plugin function
  * @returns {*} Chainable hooked function.
  */
@@ -344,7 +344,8 @@ const makeNewProfiledTapFn = (hookName, tracer, { name, type, fn }) => {
 					id,
 					cat: defaultCategory
 				});
-				return fn(...args).then(r => {
+				const promise = /** @type {Promise<*>} */ (fn(...args));
+				return promise.then(r => {
 					tracer.trace.end({
 						name,
 						id,
