More type fixes (these changes should be merged as separate PRs

Mohsen Azimi · sokra · commit 5b236e53da39 · 2018-04-12T11:42:39.000+02:00
diff --git a/lib/debug/ProfilingPlugin.js b/lib/debug/ProfilingPlugin.js
@@ -320,13 +320,24 @@ const makeInterceptorFor = (instance, tracer) => hookName => ({
 	}
 });
 
+/**
+ * @typedef NewProfiledTapOptions
+ * @property {string} name
+ * @property {string} type
+ * @property {Function} fn
+ * @description Options for the profiled fn.
+ */
+
 /**
  * @param {string} hookName Name of the hook to profile.
  * @param {{counter: number, trace: *, profiler: *}} tracer Instance of tracer.
- * @param {{name: string, type: string, fn: Function}} opts Options for the profiled fn.
  * @returns {*} Chainable hooked function.
  */
-const makeNewProfiledTapFn = (hookName, tracer, { name, type, fn }) => {
+const makeNewProfiledTapFn = (
+	hookName,
+	tracer,
+	/** @type {NewProfiledTapOptions} */ { name, type, fn }
+) => {
 	const defaultCategory = ["blink.user_timing"];
 
 	switch (type) {
diff --git a/lib/dependencies/HarmonyAcceptImportDependency.js b/lib/dependencies/HarmonyAcceptImportDependency.js
@@ -8,6 +8,7 @@ const HarmonyImportDependency = require("./HarmonyImportDependency");
 class HarmonyAcceptImportDependency extends HarmonyImportDependency {
 	constructor(request, originModule, parserScope) {
 		super(request, originModule, NaN, parserScope);
+		this.isImportEmitted = undefined;
 		this.weak = true;
 	}
 
diff --git a/lib/util/objectToMap.js b/lib/util/objectToMap.js
@@ -7,6 +7,10 @@
  */
 module.exports = function objectToMap(obj) {
 	return new Map(
-		Object.keys(obj).map(key => /** @type [string, string] */ [key, obj[key]])
+		Object.keys(obj).map(key => {
+			/** @type {[string, string]} */
+			const pair = [key, obj[key]];
+			return pair;
+		})
 	);
 };

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@ const HarmonyImportDependency = require("./HarmonyImportDependency");`
`8`	`8`	`class HarmonyAcceptImportDependency extends HarmonyImportDependency {`
`9`	`9`	`constructor(request, originModule, parserScope) {`
`10`	`10`	`super(request, originModule, NaN, parserScope);`
	`11`	`+ this.isImportEmitted = undefined;`
`11`	`12`	`this.weak = true;`
`12`	`13`	`}`
`13`	`14`