Merge pull request webpack#6974 from mohsen1/webpack-error-refactor

sokra · web-flow · commit 4d9eb7cade95 · 2018-04-12T10:00:30.000+02:00
Refactor WebpackError to initialize details as undefined
diff --git a/lib/WebpackError.js b/lib/WebpackError.js
@@ -5,6 +5,14 @@
 "use strict";
 
 module.exports = class WebpackError extends Error {
+	constructor(message) {
+		super(message);
+
+		this.details = undefined;
+
+		Error.captureStackTrace(this, this.constructor);
+	}
+
 	inspect() {
 		return this.stack + (this.details ? `\n${this.details}` : "");
 	}
diff --git a/test/RemovedPlugins.unittest.js b/test/RemovedPlugins.unittest.js
@@ -4,14 +4,15 @@ require("should");
 
 describe("removed plugin errors", () => {
 	it("should error when accessing removed plugins", () => {
-		(() => webpack.optimize.UglifyJsPlugin).should.throw(
-			RemovedPluginError,
-			/webpack\.optimize\.UglifyJsPlugin has been removed, please use config\.optimization\.minimize instead\./
-		);
+		(() => webpack.optimize.UglifyJsPlugin).should.throw(RemovedPluginError, {
+			message: /webpack\.optimize\.UglifyJsPlugin has been removed, please use config\.optimization\.minimize instead\./
+		});
 
 		(() => webpack.optimize.CommonsChunkPlugin).should.throw(
 			RemovedPluginError,
-			/webpack\.optimize\.CommonsChunkPlugin has been removed, please use config\.optimization\.splitChunks instead\./
+			{
+				message: /webpack\.optimize\.CommonsChunkPlugin has been removed, please use config\.optimization\.splitChunks instead\./
+			}
 		);
 	});
 });
