Skip to content

Commit 485fc1d

Browse files
committed
more detailed message for missing tests
1 parent 0efff8f commit 485fc1d

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

open-bot.yaml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,11 +96,13 @@ rules:
9696
comment:
9797
identifier: "tests-result"
9898
message: |-
99-
It looks like this Pull Request doesn't include [enough test cases]({{status.target_url}}).
99+
It looks like this Pull Request doesn't include [enough test cases]({{status.target_url}}) (based on Code Coverage analysis of the PR diff).
100100
101-
@{{issue.user.login}} Please add more test cases.
101+
A PR need to be covered by tests if you add a new feature (we want to make sure that your feature is working) or if you fix a bug (we want to make sure that we don't run into a regression in future).
102102
103-
See [test readme](https://github.com/webpack/webpack/blob/master/test/README.md) for details how to write test cases.
103+
@{{issue.user.login}} Please check if this is appliable to your PR and if you can add more test cases.
104+
105+
Read the [test readme](https://github.com/webpack/webpack/blob/master/test/README.md) for details how to write test cases.
104106
105107
106108

0 commit comments

Comments
 (0)