Merge pull request webpack#6905 from xtuc/fix-handle-unknown-size

sokra · web-flow · commit 3f995177b095 · 2018-04-17T11:13:23.000+02:00
SizeFormatHelpers: defend against invalid sizes
diff --git a/lib/SizeFormatHelpers.js b/lib/SizeFormatHelpers.js
@@ -7,6 +7,10 @@
 const SizeFormatHelpers = exports;
 
 SizeFormatHelpers.formatSize = size => {
+	if (typeof size !== "number" || Number.isNaN(size) === true) {
+		return "unknown size";
+	}
+
 	if (size <= 0) {
 		return "0 bytes";
 	}
diff --git a/test/SizeFormatHelpers.unittest.js b/test/SizeFormatHelpers.unittest.js
@@ -43,5 +43,10 @@ describe("SizeFormatHelpers", () => {
 				"1.2 GiB"
 			);
 		});
+
+		it("should handle undefined/NaN", () => {
+			should(SizeFormatHelpers.formatSize(undefined)).be.eql("unknown size");
+			should(SizeFormatHelpers.formatSize(NaN)).be.eql("unknown size");
+		});
 	});
 });
