fix bug where sometimes the runtime would not be present on output

alejandroMA · alejandroMA · commit 3b6d7d873ecb · 2018-04-23T17:30:14.000-05:00
diff --git a/lib/Chunk.js b/lib/Chunk.js
@@ -50,6 +50,7 @@ class Chunk {
 		this.ids = null;
 		this.debugId = debugId++;
 		this.name = name;
+		this.isRuntimeOnly = false;
 		this.entryModule = undefined;
 		this._modules = new SortableSet(undefined, sortByIdentifier);
 		this._groups = new SortableSet(undefined, sortById);
@@ -265,6 +266,9 @@ class Chunk {
 			}
 			return true;
 		};
+
+		if (otherChunk.isRuntimeOnly) return false;
+
 		if (this.hasRuntime() !== otherChunk.hasRuntime()) {
 			if (this.hasRuntime()) {
 				return isAvailable(this, otherChunk);
diff --git a/lib/optimize/RuntimeChunkPlugin.js b/lib/optimize/RuntimeChunkPlugin.js
@@ -25,6 +25,7 @@ module.exports = class RuntimeChunkPlugin {
 							name = name(entrypoint);
 						}
 						const newChunk = compilation.addChunk(name);
+						newChunk.isRuntimeOnly = true;
 						entrypoint.unshiftChunk(newChunk);
 						newChunk.addGroup(entrypoint);
 						entrypoint.setRuntimeChunk(newChunk);
diff --git a/test/statsCases/runtime-chunk-integration/b.js b/test/statsCases/runtime-chunk-integration/b.js
@@ -0,0 +1 @@
+export default "b";
diff --git a/test/statsCases/runtime-chunk-integration/expected.txt b/test/statsCases/runtime-chunk-integration/expected.txt
@@ -0,0 +1,7 @@
+      Asset       Size  Chunks             Chunk Names
+       0.js  287 bytes       0  [emitted]  
+   main1.js  386 bytes       1  [emitted]  main1
+manifest.js   7.73 KiB       2  [emitted]  manifest
+Entrypoint main1 = manifest.js main1.js
+[0] ./b.js 20 bytes {0} [built]
+[1] ./main1.js 36 bytes {1} [built]
diff --git a/test/statsCases/runtime-chunk-integration/main1.js b/test/statsCases/runtime-chunk-integration/main1.js
@@ -0,0 +1,3 @@
+import("./b");
+
+export default "a";
diff --git a/test/statsCases/runtime-chunk-integration/webpack.config.js b/test/statsCases/runtime-chunk-integration/webpack.config.js
@@ -0,0 +1,28 @@
+const MinChunkSizePlugin = require("../../../lib/optimize/MinChunkSizePlugin");
+
+module.exports = {
+	mode: "production",
+	target: "web",
+	entry: {
+		main1: "./main1"
+	},
+	output: {
+		filename: "[name].js"
+	},
+	optimization: {
+		runtimeChunk: {
+			name: "manifest"
+		}
+	},
+	stats: {
+		hash: false,
+		timings: false,
+		builtAt: false,
+		reasons: false
+	},
+	plugins: [
+		new MinChunkSizePlugin({
+			minChunkSize: 30
+		})
+	]
+};

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@ module.exports = class RuntimeChunkPlugin {`
`25`	`25`	`name = name(entrypoint);`
`26`	`26`	`}`
`27`	`27`	`const newChunk = compilation.addChunk(name);`
	`28`	`+ newChunk.isRuntimeOnly = true;`
`28`	`29`	`entrypoint.unshiftChunk(newChunk);`
`29`	`30`	`newChunk.addGroup(entrypoint);`
`30`	`31`	`entrypoint.setRuntimeChunk(newChunk);`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+import("./b");`
	`2`	`+`
	`3`	`+export default "a";`