Added chunkFilenameDelimiter option for SplitChunksPlugin

ManuelBauer · ManuelBauer · commit 36db321e9c23 · 2018-03-09T10:12:23.000+01:00
diff --git a/lib/WebpackOptionsDefaulter.js b/lib/WebpackOptionsDefaulter.js
@@ -210,6 +210,7 @@ class WebpackOptionsDefaulter extends OptionsDefaulter {
 		this.set("optimization.splitChunks.minSize", 30000);
 		this.set("optimization.splitChunks.minChunks", 1);
 		this.set("optimization.splitChunks.maxAsyncRequests", 5);
+		this.set("optimization.splitChunks.chunkFilenameDelimiter", "~");
 		this.set("optimization.splitChunks.maxInitialRequests", 3);
 		this.set("optimization.splitChunks.name", true);
 		this.set("optimization.splitChunks.cacheGroups", {});
diff --git a/lib/WebpackOptionsValidationError.js b/lib/WebpackOptionsValidationError.js
@@ -65,7 +65,7 @@ class WebpackOptionsValidationError extends WebpackError {
 
 		this.name = "WebpackOptionsValidationError";
 		this.message =
-			"Invalid configuration object. " +
+			"Invalid configuration object. :( " +
 			"Webpack has been initialised using a configuration object that does not match the API schema.\n" +
 			validationErrors
 				.map(
diff --git a/lib/optimize/SplitChunksPlugin.js b/lib/optimize/SplitChunksPlugin.js
@@ -94,7 +94,8 @@ module.exports = class SplitChunksPlugin {
 			filename: options.filename || undefined,
 			getCacheGroups: SplitChunksPlugin.normalizeCacheGroups(
 				options.cacheGroups
-			)
+			),
+			chunkFilenameDelimiter: options.chunkFilenameDelimiter || '~'
 		};
 	}
 
@@ -105,15 +106,15 @@ module.exports = class SplitChunksPlugin {
 				if (!names.every(Boolean)) return;
 				names.sort();
 				let name =
-					(cacheGroup && cacheGroup !== "default" ? cacheGroup + "~" : "") +
-					names.join("~");
+					(cacheGroup && cacheGroup !== "default" ? cacheGroup + this.options.chunkFilenameDelimiter : "") +
+					names.join(this.options.chunkFilenameDelimiter);
 				// Filenames and paths can't be too long otherwise an
 				// ENAMETOOLONG error is raised. If the generated name if too
 				// long, it is truncated and a hash is appended. The limit has
 				// been set to 100 to prevent `[name].[chunkhash].[ext]` from
 				// generating a 256+ character string.
 				if (name.length > 100) {
-					name = name.slice(0, 100) + "~" + hashFilename(name);
+					name = name.slice(0, 100) + this.options.chunkFilenameDelimiter + hashFilename(name);
 				}
 				return name;
 			};
diff --git a/schemas/WebpackOptions.json b/schemas/WebpackOptions.json
@@ -1382,6 +1382,11 @@
                   "type": "string",
                   "minLength": 1
                 },
+                "chunkFilenameDelimiter": {
+                  "description": "Sets the filename delimiter for created chunks",
+                  "type": "string",
+                  "minLength": 1
+                },
                 "cacheGroups": {
                   "description": "Assign modules to a cache group (modules from different cache groups are tried to keep in separate chunks)",
                   "type": "object",
