Merge pull request webpack#7010 from webpack/fix/context_dependency_init

sokra · web-flow · commit 25f8637de290 · 2018-04-11T08:22:27.000+02:00
Add missing field definition in ContextDependency
diff --git a/lib/dependencies/ContextDependency.js b/lib/dependencies/ContextDependency.js
@@ -14,6 +14,7 @@ class ContextDependency extends Dependency {
 		super();
 		this.options = options;
 		this.userRequest = this.options.request;
+		this.critical = false;
 		this.hadGlobalOrStickyRegExp = false;
 		if (this.options.regExp.global || this.options.regExp.sticky) {
 			this.options.regExp = null;
@@ -47,6 +48,7 @@ class ContextDependency extends Dependency {
 	}
 }
 
+// TODO remove in webpack 5
 Object.defineProperty(ContextDependency.prototype, "async", {
 	configurable: false,
 	get() {

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@ class ContextDependency extends Dependency {`
`14`	`14`	`super();`
`15`	`15`	`this.options = options;`
`16`	`16`	`this.userRequest = this.options.request;`
	`17`	`+ this.critical = false;`
`17`	`18`	`this.hadGlobalOrStickyRegExp = false;`
`18`	`19`	`if (this.options.regExp.global \|\| this.options.regExp.sticky) {`
`19`	`20`	`this.options.regExp = null;`
`@@ -47,6 +48,7 @@ class ContextDependency extends Dependency {`
`47`	`48`	`}`
`48`	`49`	`}`
`49`	`50`
	`51`	`+// TODO remove in webpack 5`
`50`	`52`	`Object.defineProperty(ContextDependency.prototype, "async", {`
`51`	`53`	`configurable: false,`
`52`	`54`	`get() {`