Merge pull request webpack#7020 from mohsen1/avoid-type-mismatch-assignments

sokra · web-flow · commit 13ac6a15eecb · 2018-04-12T09:08:54.000+02:00
Avoid type mismatch assignment of number to string in HotModuleReplacementPlugin
diff --git a/lib/HotModuleReplacementPlugin.js b/lib/HotModuleReplacementPlugin.js
@@ -145,8 +145,8 @@ module.exports = class HotModuleReplacementPlugin {
 							h: compilation.hash,
 							c: {}
 						};
-						for (let chunkId of Object.keys(records.chunkHashs)) {
-							chunkId = isNaN(+chunkId) ? chunkId : +chunkId;
+						for (const key of Object.keys(records.chunkHashs)) {
+							const chunkId = isNaN(+key) ? key : +key;
 							const currentChunk = compilation.chunks.find(
 								chunk => chunk.id === chunkId
 							);
