Use ts nightly and fix JSDoc for comment method in RuntimeTemplate

Mohsen Azimi · sokra · commit 0ea9b980f6fe · 2018-04-12T11:42:39.000+02:00
diff --git a/lib/RuntimeTemplate.js b/lib/RuntimeTemplate.js
@@ -6,30 +6,22 @@
 
 const Template = require("./Template");
 
-/**
- * @typedef CommentOptions
- * @property {string=} request
- * @property {string=} chunkName
- * @property {string=} chunkReason
- * @property {string=} message
- * @property {string=} exportName
- */
-
 module.exports = class RuntimeTemplate {
 	constructor(outputOptions, requestShortener) {
 		this.outputOptions = outputOptions || {};
 		this.requestShortener = requestShortener;
 	}
 
-	comment(
-		/** @type {CommentOptions} */ {
-			request,
-			chunkName,
-			chunkReason,
-			message,
-			exportName
-		}
-	) {
+	/**
+	 * Add a comment
+	 * @param {object} options
+	 * @param {string=} options.request
+	 * @param {string=} options.chunkName
+	 * @param {string=} options.chunkReason
+	 * @param {string=} options.message
+	 * @param {string=} options.exportName
+	 */
+	comment({ request, chunkName, chunkReason, message, exportName }) {
 		let content;
 		if (this.outputOptions.pathinfo) {
 			content = [message, request, chunkName, chunkReason]
diff --git a/package.json b/package.json
@@ -63,7 +63,7 @@
     "simple-git": "^1.65.0",
     "sinon": "^2.3.2",
     "style-loader": "^0.19.1",
-    "typescript": "^2.9.0-dev.20180405",
+    "typescript": "^2.9.0-dev.20180411",
     "url-loader": "^0.6.2",
     "val-loader": "^1.0.2",
     "vm-browserify": "~0.0.0",
@@ -110,7 +110,6 @@
     "prelint": "yarn setup",
     "lint": "yarn code-lint && yarn schema-lint",
     "code-lint": "eslint setup lib bin hot buildin \"test/*.js\" \"test/**/webpack.config.js\" \"examples/**/webpack.config.js\" \"schemas/**/*.js\"",
-    "tsc": "tsc --pretty",
     "fix": "yarn code-lint --fix",
     "pretty": "prettier \"setup/**/*.js\" \"lib/**/*.js\" \"bin/*.js\" \"hot/*.js\" \"buildin/*.js\" \"test/*.js\" \"test/**/webpack.config.js\" \"examples/**/webpack.config.js\" \"schemas/**/*.js\" \"declarations.d.ts\" --write",
     "schema-lint": "mocha test/*.lint.js --opts test/lint-mocha.opts",
diff --git a/yarn.lock b/yarn.lock
@@ -4498,9 +4498,9 @@ typedarray@^0.0.6:
   version "0.0.6"
   resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
 
-typescript@^2.9.0-dev.20180405:
-  version "2.9.0-dev.20180405"
-  resolved "https://registry.yarnpkg.com/typescript/-/typescript-2.9.0-dev.20180405.tgz#c204f6d1a8e5263dd3e7f153e25a4cdf0d2693ac"
+typescript@^2.9.0-dev.20180411:
+  version "2.9.0-dev.20180411"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-2.9.0-dev.20180411.tgz#0791768b1e4d4d10bfc8b84cdf1239050065c859"
 
 ua-parser-js@^0.7.9:
   version "0.7.17"
