webpack#6971: Escape chunk names for webworkers

haggholm · haggholm · commit 0aa9aa61b154 · 2018-04-05T18:58:39.000-07:00
diff --git a/lib/webworker/WebWorkerMainTemplatePlugin.js b/lib/webworker/WebWorkerMainTemplatePlugin.js
@@ -24,7 +24,7 @@ class WebWorkerMainTemplatePlugin {
 						"// object to store loaded chunks",
 						'// "1" means "already loaded"',
 						"var installedChunks = {",
-						Template.indent(chunk.ids.map(id => `${id}: 1`).join(",\n")),
+						Template.indent(chunk.ids.map(id => `${JSON.stringify(id)}: 1`).join(",\n")),
 						"};"
 					]);
 				}

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ class WebWorkerMainTemplatePlugin {`
`24`	`24`	`"// object to store loaded chunks",`
`25`	`25`	`'// "1" means "already loaded"',`
`26`	`26`	`"var installedChunks = {",`
`27`		- Template.indent(chunk.ids.map(id => `${id}: 1`).join(",\n")),
	`27`	+ Template.indent(chunk.ids.map(id => `${JSON.stringify(id)}: 1`).join(",\n")),
`28`	`28`	`"};"`
`29`	`29`	`]);`
`30`	`30`	`}`