Merge pull request webpack#6375 from webpack/bugfix/optimization-only-on-main

sokra · web-flow · commit 0857defcbe77 · 2018-01-24T21:29:17.000+01:00
run splitChunks and runtimeChunk only on main compiliation
diff --git a/lib/optimize/RuntimeChunkPlugin.js b/lib/optimize/RuntimeChunkPlugin.js
@@ -8,7 +8,7 @@ module.exports = class RuntimeChunkPlugin {
 	constructor(options) {}
 
 	apply(compiler) {
-		compiler.hooks.compilation.tap("RuntimeChunkPlugin", compilation => {
+		compiler.hooks.thisCompilation.tap("RuntimeChunkPlugin", compilation => {
 			compilation.hooks.optimizeChunksAdvanced.tap("RuntimeChunkPlugin", () => {
 				for(const entrypoint of compilation.entrypoints.values()) {
 					const chunk = entrypoint.getRuntimeChunk();
diff --git a/lib/optimize/SplitChunksPlugin.js b/lib/optimize/SplitChunksPlugin.js
@@ -176,7 +176,7 @@ module.exports = class SplitChunksPlugin {
 	}
 
 	apply(compiler) {
-		compiler.hooks.compilation.tap("SplitChunksPlugin", compilation => {
+		compiler.hooks.thisCompilation.tap("SplitChunksPlugin", compilation => {
 			let alreadyOptimized = false;
 			compilation.hooks.unseal.tap("SplitChunksPlugin", () => {
 				alreadyOptimized = false;

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ module.exports = class SplitChunksPlugin {`
`176`	`176`	`}`
`177`	`177`
`178`	`178`	`apply(compiler) {`
`179`		`- compiler.hooks.compilation.tap("SplitChunksPlugin", compilation => {`
	`179`	`+ compiler.hooks.thisCompilation.tap("SplitChunksPlugin", compilation => {`
`180`	`180`	`let alreadyOptimized = false;`
`181`	`181`	`compilation.hooks.unseal.tap("SplitChunksPlugin", () => {`
`182`	`182`	`alreadyOptimized = false;`