Sean comments (even more code questions?)

mohsen1 · mohsen1 · commit 04d2af0825b1 · 2018-06-19T15:48:00.000-07:00
diff --git a/lib/Template.js b/lib/Template.js
@@ -24,11 +24,11 @@ const MATCH_PADDED_HYPHENS_REPLACE_REGEX = /^-|-$/g;
 
 /**
  * @typedef {Object} HasId
- * @property {number} id
+ * @property {number | string} id
  * */
 
 /**
- * @typedef {(m: Module, idx: number) => boolean} ModuleFilterPredicate
+ * @typedef {function(Module, number): boolean} ModuleFilterPredicate
  */
 
 /**
@@ -236,6 +236,7 @@ class Template {
 			source.add("[]");
 			return source;
 		}
+		/** @type {Module[]} */
 		var allModules = modules.map(module => {
 			return {
 				id: module.id,
diff --git a/lib/util/SortableSet.js b/lib/util/SortableSet.js
@@ -82,7 +82,7 @@ class SortableSet extends Set {
 	/**
 	 * Get data from cache
 	 * @param {function(SortableSet<T>): T[]} fn function to calculate value
-	 * @returns {TODO} returns result of fn(this), cached until set changes
+	 * @returns {T[]} returns result of fn(this), cached until set changes
 	 */
 	getFromCache(fn) {
 		if (this._cache === undefined) {
