false secure option should not modify the cookie path

dimac · FagnerMartinsBrack · commit f8e01f4c0cc5 · 2015-06-25T08:44:47.000-03:00
Closes js-cookiegh-54.
diff --git a/src/js.cookie.js b/src/js.cookie.js
@@ -67,7 +67,7 @@
 					attributes.expires && '; expires=' + attributes.expires.toUTCString(), // use expires attribute, max-age is not supported by IE
 					attributes.path    && '; path=' + attributes.path,
 					attributes.domain  && '; domain=' + attributes.domain,
-					attributes.secure  && '; secure'
+					attributes.secure ? '; secure' : ''
 				].join(''));
 			}
 
diff --git a/test/tests.js b/test/tests.js
@@ -174,6 +174,14 @@ QUnit.test('API for changing defaults', function (assert) {
 	assert.ok(Cookies.set('c', 'v').match(/path=\//), 'should roll back to the default path');
 });
 
+// github.com/js-cookie/js-cookie/pull/54
+QUnit.test('false secure value', function (assert) {
+	assert.expect(1);
+	var expected = 'c=v; path=/';
+	var actual = Cookies.set('c', 'v', {secure: false});
+	assert.strictEqual(actual, expected, 'false should not modify path in cookie string');
+});
+
 QUnit.module('remove', lifecycle);
 
 QUnit.test('deletion', function (assert) {

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@`
`67`	`67`	`attributes.expires && '; expires=' + attributes.expires.toUTCString(), // use expires attribute, max-age is not supported by IE`
`68`	`68`	`attributes.path && '; path=' + attributes.path,`
`69`	`69`	`attributes.domain && '; domain=' + attributes.domain,`
`70`		`- attributes.secure && '; secure'`
	`70`	`+ attributes.secure ? '; secure' : ''`
`71`	`71`	`].join(''));`
`72`	`72`	`}`
`73`	`73`