Should not throw an exception for a third party malformed cookie

FagnerMartinsBrack · FagnerMartinsBrack · commit e36ddd2e3268 · 2015-07-11T17:23:59.000-03:00
If there is a malformed cookie that cannot be decoded using the default decoding mechanism, it should be ignored and fail to read that single cookie. It should not prevent an unrelated cookie to be retrieved. Closes js-cookiegh-62.
diff --git a/src/js.cookie.js b/src/js.cookie.js
@@ -93,22 +93,24 @@
 					cookie = cookie.slice(1, -1);
 				}
 
-				cookie = converter && converter(cookie, name) || cookie.replace(rdecode, decodeURIComponent);
+				try {
+					cookie = converter && converter(cookie, name) || cookie.replace(rdecode, decodeURIComponent);
 
-				if (this.json) {
-					try {
-						cookie = JSON.parse(cookie);
-					} catch (e) {}
-				}
+					if (this.json) {
+						try {
+							cookie = JSON.parse(cookie);
+						} catch (e) {}
+					}
 
-				if (key === name) {
-					result = cookie;
-					break;
-				}
+					if (key === name) {
+						result = cookie;
+						break;
+					}
 
-				if (!key) {
-					result[name] = cookie;
-				}
+					if (!key) {
+						result[name] = cookie;
+					}
+				} catch (e) {}
 			}
 
 			return result;
diff --git a/test/tests.js b/test/tests.js
@@ -79,6 +79,16 @@ QUnit.test('RFC 6265 - reading cookie-octet enclosed in DQUOTE', function (asser
 	assert.strictEqual(Cookies.get('c'), 'v', 'should simply ignore quoted strings');
 });
 
+// github.com/js-cookie/js-cookie/pull/62
+QUnit.test('Call to read cookie when there is another unrelated cookie with malformed encoding in the value', function (assert) {
+	assert.expect(2);
+	document.cookie = 'invalid=%A1';
+	document.cookie = 'c=v';
+	assert.strictEqual(Cookies.get('c'), 'v', 'should not throw a URI malformed exception when retrieving a single cookie');
+	assert.deepEqual(Cookies.get(), { c: 'v' }, 'should not throw a URI malformed exception when retrieving all cookies');
+	Cookies.withConverter(unescape).remove('invalid');
+});
+
 QUnit.module('write', lifecycle);
 
 QUnit.test('String primitive', function (assert) {
