Let the tile contents specify whether it requires a sender profile or not. Fixes element-hq#250.

dbkr · dbkr · commit 7c6fb36520d2 · 2015-10-23T09:24:25.000+01:00
diff --git a/src/skins/vector/views/molecules/EventAsTextTile.js b/src/skins/vector/views/molecules/EventAsTextTile.js
@@ -19,22 +19,22 @@ limitations under the License.
 var React = require('react');
 
 var EventAsTextTileController = require('matrix-react-sdk/lib/controllers/molecules/EventAsTextTile')
-var sdk = require('matrix-react-sdk')
 var TextForEvent = require('matrix-react-sdk/lib/TextForEvent');
 
 module.exports = React.createClass({
     displayName: 'EventAsTextTile',
     mixins: [EventAsTextTileController],
 
-    render: function() {
-        var MessageTimestamp = sdk.getComponent('atoms.MessageTimestamp');
-        var MemberAvatar = sdk.getComponent('atoms.MemberAvatar');
+    statics: {
+        needsSenderProfile: function() {
+            return false;
+        }
+    },
 
+    render: function() {
         var text = TextForEvent.textForEvent(this.props.mxEvent);
         if (text == null || text.length == 0) return null;
 
-        var timestamp = this.props.last ? <MessageTimestamp ts={this.props.mxEvent.getTs()} /> : null;
-        var avatar = this.props.mxEvent.sender ? <MemberAvatar member={this.props.mxEvent.sender} /> : null;
         return (
             <div className="mx_EventAsTextTile">
                 {TextForEvent.textForEvent(this.props.mxEvent)}
diff --git a/src/skins/vector/views/molecules/EventTile.js b/src/skins/vector/views/molecules/EventTile.js
@@ -114,7 +114,9 @@ module.exports = React.createClass({
                     </div>
                 );
             }
-            sender = <SenderProfile mxEvent={this.props.mxEvent} aux={aux} />;
+            if (EventTileType.needsSenderProfile()) {
+                sender = <SenderProfile mxEvent={this.props.mxEvent} aux={aux} />;
+            }
         }
         return (
             <div className={classes}>
diff --git a/src/skins/vector/views/molecules/MessageTile.js b/src/skins/vector/views/molecules/MessageTile.js
@@ -28,6 +28,12 @@ module.exports = React.createClass({
     displayName: 'MessageTile',
     mixins: [MessageTileController],
 
+    statics: {
+        needsSenderProfile: function() {
+            return true;
+        }
+    },
+
     render: function() {
         var UnknownMessageTile = sdk.getComponent('molecules.UnknownMessageTile');
 

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,9 @@ module.exports = React.createClass({`
`114`	`114`	`</div>`
`115`	`115`	`);`
`116`	`116`	`}`
`117`		`- sender = <SenderProfile mxEvent={this.props.mxEvent} aux={aux} />;`
	`117`	`+ if (EventTileType.needsSenderProfile()) {`
	`118`	`+ sender = <SenderProfile mxEvent={this.props.mxEvent} aux={aux} />;`
	`119`	`+ }`
`118`	`120`	`}`
`119`	`121`	`return (`
`120`	`122`	`<div className={classes}>`