Skip to content

Commit fe8ff5f

Browse files
schuayCommit Bot
authored andcommitted
[test] Add stress_snapshot test variant
This variant passes the --stress-snapshot d8 flag. There's a large initial list of skips, these should be removed as issues are fixed over time. The variant is currently not enabled on any bots. Bug: v8:10416 Change-Id: I80aea80600c51b2f5d28b8ec8a09ff0ba2ebaa7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2179002 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#67536}
1 parent 22861ce commit fe8ff5f

2 files changed

Lines changed: 76 additions & 0 deletions

File tree

test/mjsunit/mjsunit.status

Lines changed: 74 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1191,4 +1191,78 @@
11911191
'compiler/number-toboolean': [SKIP],
11921192
}], # variant == assert_types
11931193

1194+
##############################################################################
1195+
['variant == stress_snapshot', {
1196+
# TODO(jgruber): Remove this wildcard line ASAP.
1197+
'*': [SKIP],
1198+
1199+
# Crashes the serializer due to recursion.
1200+
'deep-recursion': [SKIP],
1201+
# Check failed: !field_type.NowStable() || field_type.NowContains(value).
1202+
'eval': [SKIP],
1203+
'regress/regress-737588': [SKIP],
1204+
'regress/regress-crbug-716520': [SKIP],
1205+
# Debug check failed:
1206+
# map == GetReadOnlyRoots(isolate).fixed_array_map() || map == GetReadOnlyRoots(isolate).fixed_cow_array_map().
1207+
# This means a mismatch of elements kinds / elements on the global object.
1208+
'es6/block-sloppy-function': [SKIP],
1209+
'es6/reflect-get-own-property-descriptor': [SKIP],
1210+
'es6/reflect': [SKIP],
1211+
'get-own-property-descriptor': [SKIP],
1212+
'global-properties': [SKIP],
1213+
'indexed-accessors': [SKIP],
1214+
'object-freeze-global': [SKIP],
1215+
'object-seal-global': [SKIP],
1216+
'regress/regress-1103': [SKIP],
1217+
'regress/regress-1112': [SKIP],
1218+
'regress/regress-1120': [SKIP],
1219+
'regress/regress-2346': [SKIP],
1220+
'regress/regress-489151': [SKIP],
1221+
'regress/regress-crbug-1002628': [SKIP],
1222+
'regress/regress-crbug-454091': [SKIP],
1223+
'regress/regress-crbug-663750': [SKIP],
1224+
'regress/regress-freeze-setter': [SKIP],
1225+
# TODO(v8:10495): Serialization now clears feedback vectors of the host
1226+
# isolate, but then execution cannot continue.
1227+
'compiler/regress-1028208': [SKIP],
1228+
'compiler/regress-1037771': [SKIP],
1229+
'es6/promises': [SKIP],
1230+
'serialize-deserialize-now': [SKIP],
1231+
'string-case': [SKIP],
1232+
# TODO(v8:10494): asm Code objects can't be flushed and end up in the isolate
1233+
# serializer.
1234+
'asm/*': [SKIP],
1235+
'compiler/regress-439743': [SKIP],
1236+
'regress/regress-441099': [SKIP],
1237+
'regress/regress-617526': [SKIP],
1238+
'regress/regress-6196': [SKIP],
1239+
'regress/regress-677685': [SKIP],
1240+
'regress/regress-7893': [SKIP],
1241+
'regress/regress-799690': [SKIP],
1242+
'regress/regress-8377': [SKIP],
1243+
'regress/regress-crbug-898974': [SKIP],
1244+
'regress/regress-crbug-935800': [SKIP],
1245+
'regress/regress-crbug-976934': [SKIP],
1246+
'regress/wasm/*': [SKIP],
1247+
'wasm/*': [SKIP],
1248+
# Investigate (IsScript).
1249+
'harmony/import-from-compilation-errored': [SKIP],
1250+
'harmony/private-fields-special-object': [SKIP],
1251+
# Investigate (JSFunction in startup serializer).
1252+
'regress/regress-1034394': [SKIP],
1253+
'regress/regress-863810': [SKIP],
1254+
'regress/regress-crbug-772056': [SKIP],
1255+
# Investigate (Check failed: buffer.byte_length() <= Smi::kMaxValue)
1256+
'regress/regress-319722-ArrayBuffer': [SKIP],
1257+
'regress/regress-599717': [SKIP],
1258+
'regress/regress-667603': [SKIP],
1259+
# Investigate (IsFixedArrayBase).
1260+
'regress/regress-786784': [SKIP],
1261+
'regress/regress-v8-9656': [SKIP],
1262+
# Investigate (startup_serializer_->ReferenceMapContains(obj)).
1263+
'regress/regress-813440': [SKIP],
1264+
# Investigate (segfault).
1265+
'regress/regress-crbug-397662': [SKIP],
1266+
}], # variant == stress_snapshot
1267+
11941268
]

tools/testrunner/local/variants.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
"stress_js_bg_compile_wasm_code_gc": [["--stress-background-compile",
2929
"--stress-wasm-code-gc"]],
3030
"stress_incremental_marking": [["--stress-incremental-marking"]],
31+
"stress_snapshot": [["--stress-snapshot"]],
3132
# Trigger stress sampling allocation profiler with sample interval = 2^14
3233
"stress_sampling": [["--stress-sampling-allocation-profiler=16384"]],
3334
"trusted": [["--no-untrusted-code-mitigations"]],
@@ -40,6 +41,7 @@
4041

4142
SLOW_VARIANTS = set([
4243
'stress',
44+
'stress_snapshot',
4345
'nooptimization',
4446
])
4547

0 commit comments

Comments
 (0)