Fix inspector tests for shared libraries.

Ilija.Pavlovic · Commit bot · commit ab341eab8cd8 · 2017-05-09T06:30:17.000Z
This CL prevents problems with library libicui18n.so during execution inspector tests when component is defined as shared library. TEST=inspector/* BUG= Review-Url: https://codereview.chromium.org/2863383003 Cr-Commit-Position: refs/heads/master@{#45176}
diff --git a/test/inspector/BUILD.gn b/test/inspector/BUILD.gn
@@ -28,6 +28,10 @@ v8_executable("inspector-test") {
     "//build/win:default_exe_manifest",
   ]
 
+  if (v8_enable_i18n_support) {
+    deps += [ "//third_party/icu" ]
+  }
+
   cflags = []
   ldflags = []
 }
diff --git a/test/inspector/inspector.gyp b/test/inspector/inspector.gyp
@@ -26,6 +26,14 @@
         'task-runner.cc',
         'task-runner.h',
       ],
+      'conditions': [
+        ['v8_enable_i18n_support==1', {
+          'dependencies': [
+            '<(icu_gyp_path):icui18n',
+            '<(icu_gyp_path):icuuc',
+          ],
+        }],
+      ],
     },
   ],
   'conditions': [

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,10 @@ v8_executable("inspector-test") {`
`28`	`28`	`"//build/win:default_exe_manifest",`
`29`	`29`	`]`
`30`	`30`
	`31`	`+ if (v8_enable_i18n_support) {`
	`32`	`+ deps += [ "//third_party/icu" ]`
	`33`	`+ }`
	`34`	`+`
`31`	`35`	`cflags = []`
`32`	`36`	`ldflags = []`
`33`	`37`	`}`