Skip to content

Commit a5fa093

Browse files
committed
introduce android_x64 build target
BUG= R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/966773005 Cr-Commit-Position: refs/heads/master@{#27055}
1 parent 9633eba commit a5fa093

6 files changed

Lines changed: 30 additions & 7 deletions

File tree

Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,8 @@ ARCHES = ia32 x64 x32 arm arm64 mips mipsel mips64el x87 ppc ppc64
234234
DEFAULT_ARCHES = ia32 x64 arm
235235
MODES = release debug optdebug
236236
DEFAULT_MODES = release debug
237-
ANDROID_ARCHES = android_ia32 android_arm android_arm64 android_mipsel android_x87
237+
ANDROID_ARCHES = android_ia32 android_x64 android_arm android_arm64 \
238+
android_mipsel android_x87
238239
NACL_ARCHES = nacl_ia32 nacl_x64
239240

240241
# List of files that trigger Makefile regeneration:

Makefile.android

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@
2626
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
2727

2828
# Those definitions should be consistent with the main Makefile
29-
ANDROID_ARCHES = android_ia32 android_arm android_arm64 android_mipsel android_x87
29+
ANDROID_ARCHES = android_ia32 android_x64 android_arm android_arm64 \
30+
android_mipsel android_x87
3031
MODES = release debug
3132

3233
# Generates all combinations of ANDROID ARCHES and MODES,
@@ -66,6 +67,11 @@ else ifeq ($(ARCH), android_ia32)
6667
TOOLCHAIN_ARCH = x86
6768
TOOLCHAIN_PREFIX = i686-linux-android
6869
TOOLCHAIN_VER = 4.8
70+
else ifeq ($(ARCH), android_x64)
71+
DEFINES = target_arch=x64 v8_target_arch=x64 android_target_arch=x86_64 android_target_platform=21
72+
TOOLCHAIN_ARCH = x86_64
73+
TOOLCHAIN_PREFIX = x86_64-linux-android
74+
TOOLCHAIN_VER = 4.9
6975
else ifeq ($(ARCH), android_x87)
7076
DEFINES = target_arch=x87 v8_target_arch=x87 android_target_arch=x86 android_target_platform=14
7177
TOOLCHAIN_ARCH = x86

build/android.gypi

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,13 @@
4343
'android_stlport': '<(android_toolchain)/sources/cxx-stl/stlport/',
4444
},
4545
'android_include': '<(android_sysroot)/usr/include',
46-
'android_lib': '<(android_sysroot)/usr/lib',
46+
'conditions': [
47+
['target_arch=="x64"', {
48+
'android_lib': '<(android_sysroot)/usr/lib64',
49+
}, {
50+
'android_lib': '<(android_sysroot)/usr/lib',
51+
}],
52+
],
4753
'android_stlport_include': '<(android_stlport)/stlport',
4854
'android_stlport_libs': '<(android_stlport)/libs',
4955
}, {
@@ -52,7 +58,13 @@
5258
'android_stlport': '<(android_ndk_root)/sources/cxx-stl/stlport/',
5359
},
5460
'android_include': '<(android_sysroot)/usr/include',
55-
'android_lib': '<(android_sysroot)/usr/lib',
61+
'conditions': [
62+
['target_arch=="x64"', {
63+
'android_lib': '<(android_sysroot)/usr/lib64',
64+
}, {
65+
'android_lib': '<(android_sysroot)/usr/lib',
66+
}],
67+
],
5668
'android_stlport_include': '<(android_stlport)/stlport',
5769
'android_stlport_libs': '<(android_stlport)/libs',
5870
}],
@@ -227,7 +239,7 @@
227239
'target_conditions': [
228240
['_type=="executable"', {
229241
'conditions': [
230-
['target_arch=="arm64"', {
242+
['target_arch=="arm64" or target_arch=="x64"', {
231243
'ldflags': [
232244
'-Wl,-dynamic-linker,/system/bin/linker64',
233245
],

tools/run-tests.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@
130130
SUPPORTED_ARCHS = ["android_arm",
131131
"android_arm64",
132132
"android_ia32",
133+
"android_x64",
133134
"arm",
134135
"ia32",
135136
"x87",
@@ -147,6 +148,7 @@
147148
SLOW_ARCHS = ["android_arm",
148149
"android_arm64",
149150
"android_ia32",
151+
"android_x64",
150152
"arm",
151153
"mips",
152154
"mipsel",

tools/run_perf.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@
111111
SUPPORTED_ARCHS = ["android_arm",
112112
"android_arm64",
113113
"android_ia32",
114+
"android_x64",
114115
"arm",
115116
"ia32",
116117
"mips",

tools/testrunner/local/statusfile.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,9 @@
5555
VARIABLES = {ALWAYS: True}
5656
for var in ["debug", "release", "big", "little",
5757
"android_arm", "android_arm64", "android_ia32", "android_x87",
58-
"arm", "arm64", "ia32", "mips", "mipsel", "mips64el", "x64", "x87", "nacl_ia32",
59-
"nacl_x64", "ppc", "ppc64", "macos", "windows", "linux", "aix"]:
58+
"android_x64", "arm", "arm64", "ia32", "mips", "mipsel",
59+
"mips64el", "x64", "x87", "nacl_ia32", "nacl_x64", "ppc", "ppc64",
60+
"macos", "windows", "linux", "aix"]:
6061
VARIABLES[var] = var
6162

6263

0 commit comments

Comments
 (0)