Skip to content

Commit a36c9cb

Browse files
psmarshallCommit Bot
authored andcommitted
cleanup: Use unique_ptr in src/logging/ and other cleanups
- Get rid of a bunch of unnecessary friend classes. This required making the constructor public - Remove log_events_ field which is not used - Use unique_ptr for owned members - Use make_unique instead of bare constructors - Use a scoped vector instead of a unique ptr to array for the dynamically sized array of WasmModules Bug: v8:9396 Change-Id: Icdca904e7227d2ce2d75caf092f259d47ff15809 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803339 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#63776}
1 parent 9113212 commit a36c9cb

4 files changed

Lines changed: 64 additions & 76 deletions

File tree

src/logging/log-utils.cc

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,16 +75,15 @@ FILE* Log::Close() {
7575
}
7676
output_handle_ = nullptr;
7777

78-
DeleteArray(format_buffer_);
79-
format_buffer_ = nullptr;
78+
format_buffer_.reset();
8079

8180
is_stopped_ = false;
8281
return result;
8382
}
8483

8584
Log::MessageBuilder::MessageBuilder(Log* log)
8685
: log_(log), lock_guard_(&log_->mutex_) {
87-
DCHECK_NOT_NULL(log_->format_buffer_);
86+
DCHECK_NOT_NULL(log_->format_buffer_.get());
8887
}
8988

9089
void Log::MessageBuilder::AppendString(String str,
@@ -185,7 +184,7 @@ void Log::MessageBuilder::AppendSymbolNameDetails(String str,
185184

186185
int Log::MessageBuilder::FormatStringIntoBuffer(const char* format,
187186
va_list args) {
188-
Vector<char> buf(log_->format_buffer_, Log::kMessageBufferSize);
187+
Vector<char> buf(log_->format_buffer_.get(), Log::kMessageBufferSize);
189188
int length = v8::internal::VSNPrintF(buf, format, args);
190189
// |length| is -1 if output was truncated.
191190
if (length == -1) length = Log::kMessageBufferSize;

src/logging/log-utils.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ class Log {
125125

126126
// Buffer used for formatting log messages. This is a singleton buffer and
127127
// mutex_ should be acquired before using it.
128-
char* format_buffer_;
128+
std::unique_ptr<char[]> format_buffer_;
129129

130130
Logger* logger_;
131131

0 commit comments

Comments
 (0)