Skip to content

Commit a05abda

Browse files
author
jochen@chromium.org
committed
Set OS=android via GYP_DEFINES
Otherwise, the variable isn't available in all scopes. Instead of playing around with nested scopes, we just set it in GYP_DEFINES (same as chromium does) BUG=v8:3405 R=ulan@chromium.org LOG=n Review URL: https://codereview.chromium.org/357643002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22004 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
1 parent 6a5ab4b commit a05abda

2 files changed

Lines changed: 1 addition & 1 deletion

File tree

Makefile.android

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ endif
9898

9999
# For mksnapshot host generation.
100100
DEFINES += host_os=${HOST_OS}
101+
DEFINES += OS=android
101102

102103
.SECONDEXPANSION:
103104
$(ANDROID_BUILDS): $(OUTDIR)/Makefile.$$@

build/android.gypi

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@
6666
'android_stlport_library': 'stlport_static',
6767
# Copy it out one scope.
6868
'android_webview_build%': '<(android_webview_build)',
69-
'OS': 'android',
7069
}, # variables
7170
'target_defaults': {
7271
'defines': [

0 commit comments

Comments
 (0)