Reland "[nojit] Check that --jitless is disabled when creating wasm code"

schuay · Commit Bot · commit 8de3a2ca441b · 2019-02-04T10:20:08.000Z
This is a reland of 0befa6d Original change's description: > [nojit] Check that --jitless is disabled when creating wasm code > > Drive-by: Amend wasm test skips for lite mode. > > Bug: v8:7777 > Change-Id: I23e13b65e548c19d6b24a26e0b962a9978f54ed7 > Reviewed-on: https://chromium-review.googlesource.com/c/1449616 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59314} Tbr: mstarzinger@chromium.org Bug: v8:7777 Change-Id: I0a076b36bb2e69b612df89b0f35067f299f27a7e Reviewed-on: https://chromium-review.googlesource.com/c/1451819 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#59325}
diff --git a/src/wasm/wasm-code-manager.cc b/src/wasm/wasm-code-manager.cc
@@ -445,6 +445,8 @@ WasmCode* NativeModule::AddOwnedCode(
     OwnedVector<const byte> reloc_info,
     OwnedVector<const byte> source_position_table, WasmCode::Kind kind,
     WasmCode::Tier tier) {
+  CHECK(!FLAG_jitless);  // TODO(jgruber): Support wasm in jitless mode.
+
   WasmCode* code;
   {
     // Both allocation and insertion in owned_code_ happen in the same critical
diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status
@@ -528,13 +528,15 @@
   'test-heap/IncrementalMarkingStepMakesBigProgressWithLargeObjects': [SKIP],
 
   # TODO(v8:7777): Re-enable once wasm is supported in jitless mode.
+  'test-api/WasmStreamingFinishWithSuccess': [SKIP],
   'test-c-wasm-entry/*': [SKIP],
   'test-jump-table-assembler/*': [SKIP],
   'test-run-wasm-64/*': [SKIP],
   'test-run-wasm-asmjs/*': [SKIP],
   'test-run-wasm-atomics64/*': [SKIP],
   'test-run-wasm-atomics/*': [SKIP],
   'test-run-wasm/*': [SKIP],
+  'test-run-wasm-exceptions/*': [SKIP],
   'test-run-wasm-interpreter/*': [SKIP],
   'test-run-wasm-js/*': [SKIP],
   'test-run-wasm-module/*': [SKIP],
diff --git a/test/debugger/debugger.status b/test/debugger/debugger.status
@@ -127,6 +127,7 @@
 ['lite_mode', {
   # TODO(v8:7777): Re-enable once wasm is supported in jitless mode.
   'debug/wasm/*': [SKIP],
+  'regress/regress-crbug-840288': [SKIP],
   'wasm-*': [SKIP],
 }], # lite_mode
 
diff --git a/test/fuzzer/fuzzer.status b/test/fuzzer/fuzzer.status
@@ -9,6 +9,7 @@
   # TODO(v8:7777): Re-enable once wasm is supported in jitless mode.
   'multi_return/*': [SKIP],
   'wasm_async/*': [SKIP],
+  'wasm_code/*': [SKIP],
   'wasm_compile/*': [SKIP],
 }], # lite_mode
 
diff --git a/test/message/message.status b/test/message/message.status
@@ -56,6 +56,7 @@
 ##############################################################################
 ['lite_mode', {
   # TODO(v8:7777): Re-enable once wasm is supported in jitless mode.
+  'mjsunit/fail/assert-promise-result-wasm-compile-fail': [SKIP],
   'fail/wasm-*': [SKIP],
   'wasm-*': [SKIP],
 
diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status
@@ -349,6 +349,11 @@
   'spread-large-array': [SKIP],
 
   # TODO(v8:7777): Re-enable once wasm is supported in jitless mode.
+  'regress/regress-5888': [SKIP],
+  'regress/regress-5911': [SKIP],
+  'regress/regress-813440': [SKIP],
+  'regress/regress-crbug-746835': [SKIP],
+  'regress/regress-crbug-772056': [SKIP],
   'regress/wasm/*': [SKIP],
   'tools/compiler-trace-flags': [SKIP],
   'wasm/*': [SKIP],
diff --git a/test/unittests/unittests.status b/test/unittests/unittests.status
@@ -25,6 +25,7 @@
 ['lite_mode', {
   # TODO(v8:7777): Re-enable once wasm is supported in jitless mode.
   'ValueSerializerTestWithWasm.*': [SKIP],
+  'Parameterized/WasmCodeManagerTest.*': [SKIP],
 }], # lite_mode
 
 ]

Original file line number	Diff line number	Diff line change
`@@ -445,6 +445,8 @@ WasmCode* NativeModule::AddOwnedCode(`
`445`	`445`	`OwnedVector<const byte> reloc_info,`
`446`	`446`	`OwnedVector<const byte> source_position_table, WasmCode::Kind kind,`
`447`	`447`	`WasmCode::Tier tier) {`
	`448`	`+ CHECK(!FLAG_jitless); // TODO(jgruber): Support wasm in jitless mode.`
	`449`	`+`
`448`	`450`	`WasmCode* code;`
`449`	`451`	`{`
`450`	`452`	`// Both allocation and insertion in owned_code_ happen in the same critical`
Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@`
`25`	`25`	`['lite_mode', {`
`26`	`26`	`# TODO(v8:7777): Re-enable once wasm is supported in jitless mode.`
`27`	`27`	`'ValueSerializerTestWithWasm.*': [SKIP],`
	`28`	`+ 'Parameterized/WasmCodeManagerTest.*': [SKIP],`
`28`	`29`	`}], # lite_mode`
`29`	`30`
`30`	`31`	`]`