Support concatenating with zero-size arrays with DICTIONARY_ELEMENTS in Runtime_ArrayConcat.

isheludko · Commit bot · commit 8ccc696bf642 · 2015-01-22T11:15:30.000Z
BUG=chromium:450895 LOG=y Review URL: https://codereview.chromium.org/849693003 Cr-Commit-Position: refs/heads/master@{#26219}
diff --git a/src/runtime/runtime-array.cc b/src/runtime/runtime-array.cc
@@ -850,6 +850,7 @@ RUNTIME_FUNCTION(Runtime_ArrayConcat) {
             }
             case FAST_HOLEY_ELEMENTS:
             case FAST_ELEMENTS:
+            case DICTIONARY_ELEMENTS:
               DCHECK_EQ(0, length);
               break;
             default:
diff --git a/test/mjsunit/regress/regress-450895.js b/test/mjsunit/regress/regress-450895.js
@@ -0,0 +1,9 @@
+// Copyright 2015 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax
+
+var v = new Array();
+Object.freeze(v);
+v = v.concat(0.5);

Original file line number	Diff line number	Diff line change
`@@ -850,6 +850,7 @@ RUNTIME_FUNCTION(Runtime_ArrayConcat) {`
`850`	`850`	`}`
`851`	`851`	`case FAST_HOLEY_ELEMENTS:`
`852`	`852`	`case FAST_ELEMENTS:`
	`853`	`+ case DICTIONARY_ELEMENTS:`
`853`	`854`	`DCHECK_EQ(0, length);`
`854`	`855`	`break;`
`855`	`856`	`default:`