[cleanup] Add missing _string suffixes

marjakh · Commit Bot · commit 785d5363b985 · 2020-05-27T14:05:16.000Z
All strings in the internalized string list now have them. Bug: v8:10506 Change-Id: I68feb34d0dc424465a53ac73a5d6b5297e29dd00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2218032 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#68014}
diff --git a/src/execution/futex-emulation.cc b/src/execution/futex-emulation.cc
@@ -89,11 +89,11 @@ Object WaitJsTranslateReturn(Isolate* isolate, Object res) {
     int val = Smi::ToInt(res);
     switch (val) {
       case WaitReturnValue::kOk:
-        return ReadOnlyRoots(isolate).ok();
+        return ReadOnlyRoots(isolate).ok_string();
       case WaitReturnValue::kNotEqual:
-        return ReadOnlyRoots(isolate).not_equal();
+        return ReadOnlyRoots(isolate).not_equal_string();
       case WaitReturnValue::kTimedOut:
-        return ReadOnlyRoots(isolate).timed_out();
+        return ReadOnlyRoots(isolate).timed_out_string();
       default:
         UNREACHABLE();
     }
diff --git a/src/init/heap-symbols.h b/src/init/heap-symbols.h
@@ -243,7 +243,7 @@
   V(_, NFD_string, "NFD")                                            \
   V(_, NFKC_string, "NFKC")                                          \
   V(_, NFKD_string, "NFKD")                                          \
-  V(_, not_equal, "not-equal")                                       \
+  V(_, not_equal_string, "not-equal")                                \
   V(_, null_string, "null")                                          \
   V(_, null_to_string, "[object Null]")                              \
   V(_, Number_string, "Number")                                      \
@@ -253,7 +253,7 @@
   V(_, object_string, "object")                                      \
   V(_, object_to_string, "[object Object]")                          \
   V(_, of_string, "of")                                              \
-  V(_, ok, "ok")                                                     \
+  V(_, ok_string, "ok")                                              \
   V(_, one_string, "1")                                              \
   V(_, other_string, "other")                                        \
   V(_, ownKeys_string, "ownKeys")                                    \
@@ -305,7 +305,7 @@
   V(_, this_function_string, ".this_function")                       \
   V(_, this_string, "this")                                          \
   V(_, throw_string, "throw")                                        \
-  V(_, timed_out, "timed-out")                                       \
+  V(_, timed_out_string, "timed-out")                                \
   V(_, toJSON_string, "toJSON")                                      \
   V(_, toString_string, "toString")                                  \
   V(_, true_string, "true")                                          \
