Delete dead/debug code in (tick|ic|map)processor.js.

bsep-chromium · Commit Bot · commit 77140c19ddde · 2018-08-16T12:31:02.000Z
Change-Id: I76264a2f912eaac0ca913004fe9ec1f57d03ecb9 Reviewed-on: https://chromium-review.googlesource.com/1177390 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#55160}
diff --git a/tools/ic-processor.js b/tools/ic-processor.js
@@ -61,7 +61,6 @@ function IcProcessor() {
         parsers : propertyICParser,
         processor: this.processPropertyIC.bind(this, "StoreInArrayLiteralIC") },
       });
-  this.deserializedEntriesNames_ = [];
   this.profile_ = new Profile();
 
   this.LoadIC = 0;
@@ -118,10 +117,6 @@ IcProcessor.prototype.addEntry = function(entry) {
 
 IcProcessor.prototype.processCodeCreation = function(
     type, kind, timestamp, start, size, name, maybe_func) {
-  name = this.deserializedEntriesNames_[start] || name;
-  if (name.startsWith("onComplete")) {
-    console.log(name);
-  }
   if (maybe_func.length) {
     var funcAddr = parseInt(maybe_func[0]);
     var state = parseState(maybe_func[1]);
diff --git a/tools/map-processor.js b/tools/map-processor.js
@@ -39,7 +39,6 @@ class MapProcessor extends LogReader {
         processor: this.processMapDetails
       }
     };
-    this.deserializedEntriesNames_ = [];
     this.profile_ = new Profile();
     this.timeline_ = new Timeline();
   }
@@ -66,7 +65,7 @@ class MapProcessor extends LogReader {
         this.processLogLine(line);
       }
     } catch(e) {
-      console.log("Error occurred during parsing, trying to continue: " + e);
+      console.error("Error occurred during parsing, trying to continue: " + e);
     }
     return this.finalize();
   }
@@ -108,10 +107,6 @@ class MapProcessor extends LogReader {
 
   processCodeCreation(
     type, kind, timestamp, start, size, name, maybe_func) {
-    name = this.deserializedEntriesNames_[start] || name;
-    if (name.startsWith("onComplete")) {
-      console.log(name);
-    }
     if (maybe_func.length) {
       let funcAddr = parseInt(maybe_func[0]);
       let state = this.parseState(maybe_func[1]);
@@ -180,9 +175,6 @@ class MapProcessor extends LogReader {
   }
 
   createMap(id, time) {
-    if (id == 0x1821257d1761) {
-      console.log(id);
-    }
     let map = new V8Map(id, time);
     this.timeline_.push(map);
     return map;
diff --git a/tools/tickprocessor.js b/tools/tickprocessor.js
@@ -160,7 +160,6 @@ function TickProcessor(
   this.stateFilter_ = stateFilter;
   this.runtimeTimerFilter_ = runtimeTimerFilter;
   this.sourceMap = sourceMap;
-  this.deserializedEntriesNames_ = [];
   var ticks = this.ticks_ =
     { total: 0, unaccounted: 0, excluded: 0, gc: 0 };
 
@@ -299,7 +298,6 @@ TickProcessor.prototype.processSharedLibrary = function(
 
 TickProcessor.prototype.processCodeCreation = function(
     type, kind, timestamp, start, size, name, maybe_func) {
-  name = this.deserializedEntriesNames_[start] || name;
   if (maybe_func.length) {
     var funcAddr = parseInt(maybe_func[0]);
     var state = parseState(maybe_func[1]);

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,6 @@ class MapProcessor extends LogReader {`
`39`	`39`	`processor: this.processMapDetails`
`40`	`40`	`}`
`41`	`41`	`};`
`42`		`- this.deserializedEntriesNames_ = [];`
`43`	`42`	`this.profile_ = new Profile();`
`44`	`43`	`this.timeline_ = new Timeline();`
`45`	`44`	`}`
`@@ -66,7 +65,7 @@ class MapProcessor extends LogReader {`
`66`	`65`	`this.processLogLine(line);`
`67`	`66`	`}`
`68`	`67`	`} catch(e) {`
`69`		`- console.log("Error occurred during parsing, trying to continue: " + e);`
	`68`	`+ console.error("Error occurred during parsing, trying to continue: " + e);`
`70`	`69`	`}`
`71`	`70`	`return this.finalize();`
`72`	`71`	`}`
`@@ -108,10 +107,6 @@ class MapProcessor extends LogReader {`
`108`	`107`
`109`	`108`	`processCodeCreation(`
`110`	`109`	`type, kind, timestamp, start, size, name, maybe_func) {`
`111`		`- name = this.deserializedEntriesNames_[start] \|\| name;`
`112`		`- if (name.startsWith("onComplete")) {`
`113`		`- console.log(name);`
`114`		`- }`
`115`	`110`	`if (maybe_func.length) {`
`116`	`111`	`let funcAddr = parseInt(maybe_func[0]);`
`117`	`112`	`let state = this.parseState(maybe_func[1]);`
`@@ -180,9 +175,6 @@ class MapProcessor extends LogReader {`
`180`	`175`	`}`
`181`	`176`
`182`	`177`	`createMap(id, time) {`
`183`		`- if (id == 0x1821257d1761) {`
`184`		`- console.log(id);`
`185`		`- }`
`186`	`178`	`let map = new V8Map(id, time);`
`187`	`179`	`this.timeline_.push(map);`
`188`	`180`	`return map;`