Reland x2 "[ptr-compr][arm64] Temporarily enable pointer compression on arm64"

santiaboy · Commit Bot · commit 52a54bd16c02 · 2019-10-22T11:37:16.000Z
This is a reland of f561140 We had to revert due to branch cut. The A/B experiment wasn't done yet. Original change's description: > [ptr-compr][arm64] Temporarily enable pointer compression on arm64 > > ... and make sure that the arm64 ptr-compr bots proceed testing V8 without > pointer compression in order to keep testing the other config. > > Commented out the 'extra' variant since it was crashing. Opened a bug > regarding that: https://bugs.chromium.org/p/v8/issues/detail?id=9568 > > Similar to x64's https://chromium-review.googlesource.com/c/v8/v8/+/1607654 > > Bug: v8:7703 > Change-Id: Ifd46b029bab34524f9f536dcdbd1574f2ddcbf37 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1724216 > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63019} Bug: v8:7703 Change-Id: I28726f534dfd17dd695a3ba5653873368e7a44b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872403 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#64459}
diff --git a/BUILD.gn b/BUILD.gn
@@ -104,7 +104,7 @@ declare_args() {
   v8_enable_verify_csa = false
 
   # Enable pointer compression (sets -dV8_COMPRESS_POINTERS).
-  v8_enable_pointer_compression = false
+  v8_enable_pointer_compression = ""
   v8_enable_31bit_smis_on_64bit_arch = false
 
   # Sets -dOBJECT_PRINT.
@@ -230,6 +230,10 @@ if (v8_check_microtasks_scopes_consistency == "") {
 if (v8_enable_snapshot_native_code_counters == "") {
   v8_enable_snapshot_native_code_counters = v8_enable_debugging_features
 }
+if (v8_enable_pointer_compression == "") {
+  # TODO(v8:v7703): temporarily enable pointer compression on arm64
+  v8_enable_pointer_compression = v8_current_cpu == "arm64"
+}
 if (v8_enable_shared_ro_heap == "") {
   v8_enable_shared_ro_heap = !v8_enable_pointer_compression
 }
diff --git a/infra/mb/mb_config.pyl b/infra/mb/mb_config.pyl
@@ -351,8 +351,11 @@
     'release_simulate_arm64': [
       'release_bot', 'simulate_arm64'],
     'release_simulate_arm64_pointer_compression': [
+      # TODO(v8:v7703): Make pointer compression bots testing non pointer
+      # compression mode while pointer compression is temporarily enabled
+      # on arm64
       'release_bot', 'simulate_arm64', 'dcheck_always_on',
-      'v8_enable_slow_dchecks', 'v8_enable_pointer_compression'],
+      'v8_enable_slow_dchecks', 'v8_disable_pointer_compression'],
     'release_simulate_arm64_msan': [
       'release_bot', 'simulate_arm64', 'msan'],
     'release_simulate_arm64_msan_minimal_symbols': [
@@ -768,6 +771,10 @@
       'gn_args': 'v8_enable_pointer_compression=true',
     },
 
+    'v8_disable_pointer_compression': {
+      'gn_args': 'v8_enable_pointer_compression=false',
+    },
+
     'v8_enable_test_features': {
       'gn_args': 'v8_enable_test_features=true',
     },
diff --git a/infra/testing/builders.pyl b/infra/testing/builders.pyl
@@ -432,7 +432,9 @@
       {'name': 'mozilla', 'shards': 2},
       {'name': 'test262', 'variant': 'default', 'shards': 2},
       {'name': 'v8testing', 'shards': 10},
-      {'name': 'v8testing', 'variant': 'extra', 'shards': 6},
+      # TODO(v8:v7703): Temporarily disable this test while enabling pointer
+      # compression on arm64.
+      # {'name': 'v8testing', 'variant': 'extra', 'shards': 6},
       {'name': 'v8testing', 'variant': 'trusted', 'shards': 3},
     ],
   },
@@ -453,7 +455,9 @@
       {'name': 'mozilla', 'shards': 2},
       {'name': 'test262', 'variant': 'default', 'shards': 2},
       {'name': 'v8testing', 'shards': 12},
-      {'name': 'v8testing', 'variant': 'extra', 'shards': 8},
+      # TODO(v8:v7703): Temporarily disable this test while enabling pointer
+      # compression on arm64.
+      # {'name': 'v8testing', 'variant': 'extra', 'shards': 8},
       {'name': 'v8testing', 'variant': 'trusted', 'shards': 3},
     ],
   },
@@ -1394,7 +1398,9 @@
       {'name': 'mozilla'},
       {'name': 'test262', 'variant': 'default'},
       {'name': 'v8testing', 'shards': 3},
-      {'name': 'v8testing', 'variant': 'extra'},
+      # TODO(v8:v7703): Temporarily disable this test while enabling pointer
+      # compression on arm64.
+      # {'name': 'v8testing', 'variant': 'extra'},
       {'name': 'v8testing', 'variant': 'trusted'},
     ],
   },
@@ -1411,7 +1417,9 @@
       {'name': 'mozilla', 'shards': 2},
       {'name': 'test262', 'variant': 'default', 'shards': 2},
       {'name': 'v8testing', 'shards': 10},
-      {'name': 'v8testing', 'variant': 'extra', 'shards': 6},
+      # TODO(v8:v7703): Temporarily disable this test while enabling pointer
+      # compression on arm64.
+      # {'name': 'v8testing', 'variant': 'extra', 'shards': 6},
       {'name': 'v8testing', 'variant': 'trusted', 'shards': 2},
     ],
   },
diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status
@@ -804,7 +804,6 @@
   'icu-date-lord-howe': [SKIP],
   'regress/regress-6288': [SKIP],
   # OOM:
-  'regress/regress-748069': [FAIL],
   'regress/regress-752764': [FAIL],
   # Flaky OOM:
   'regress/regress-779407': [SKIP],
