Skip to content

Commit 3c5d6ca

Browse files
ajkleinCommit bot
authored andcommitted
Pass all parser flags from Parser to PreParser
This revealed one Mozilla test that depended upon a lack of early error for "with ({}) function ...". The test has been marked as failing. R=littledan@chromium.org Review URL: https://codereview.chromium.org/1814863005 Cr-Commit-Position: refs/heads/master@{#34910}
1 parent 5a476db commit 3c5d6ca

2 files changed

Lines changed: 5 additions & 0 deletions

File tree

src/parsing/parser.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4686,11 +4686,13 @@ PreParser::PreParseResult Parser::ParseLazyFunctionBodyWithPreParser(
46864686
SET_ALLOW(natives);
46874687
SET_ALLOW(legacy_const);
46884688
SET_ALLOW(harmony_sloppy);
4689+
SET_ALLOW(harmony_sloppy_function);
46894690
SET_ALLOW(harmony_sloppy_let);
46904691
SET_ALLOW(harmony_do_expressions);
46914692
SET_ALLOW(harmony_function_name);
46924693
SET_ALLOW(harmony_function_sent);
46934694
SET_ALLOW(harmony_exponentiation_operator);
4695+
SET_ALLOW(harmony_restrictive_declarations);
46944696
#undef SET_ALLOW
46954697
}
46964698
PreParser::PreParseResult result = reusable_preparser_->PreParseLazyFunction(

test/mozilla/mozilla.status

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,9 @@
109109
'js1_5/Regress/regress-360969-03': [FAIL, ['mode == debug', TIMEOUT, NO_VARIANTS]],
110110
'js1_5/Regress/regress-360969-04': [FAIL, ['mode == debug', TIMEOUT, NO_VARIANTS]],
111111

112+
# Function declarations are no longer allowed as the body of a with statement.
113+
'js1_5/Regress/regress-326453': [FAIL],
114+
112115
##################### SKIPPED TESTS #####################
113116

114117
# This test checks that we behave properly in an out-of-memory

0 commit comments

Comments
 (0)