Skip to content

Commit 30a0a7d

Browse files
author
mikhail.naganov@gmail.com
committed
Split nested namespaces declaration in two lines in accordance with C++ Style Guide.
This issue was raised by Brett Wilson while reviewing my changelist for readability. Craig Silverstein (one of C++ SG maintainers) confirmed that we should declare one namespace per line. Our way of namespaces closing seems not violating style guides (there is no clear agreement on it), so I left it intact. Review URL: http://codereview.chromium.org/115756 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2038 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
1 parent 6d71da1 commit 30a0a7d

223 files changed

Lines changed: 452 additions & 226 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/accessors.cc‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@
3434
#include "top.h"
3535
#include "zone-inl.h"
3636

37-
namespace v8 { namespace internal {
37+
namespace v8 {
38+
namespace internal {
3839

3940

4041
template <class C>

‎src/accessors.h‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@
2828
#ifndef V8_ACCESSORS_H_
2929
#define V8_ACCESSORS_H_
3030

31-
namespace v8 { namespace internal {
31+
namespace v8 {
32+
namespace internal {
3233

3334
// The list of accessor descriptors. This is a second-order macro
3435
// taking a macro to be applied to all accessor descriptor names.

‎src/allocation.cc‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@
2929

3030
#include "v8.h"
3131

32-
namespace v8 { namespace internal {
32+
namespace v8 {
33+
namespace internal {
3334

3435

3536
void* Malloced::New(size_t size) {

‎src/allocation.h‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@
2828
#ifndef V8_ALLOCATION_H_
2929
#define V8_ALLOCATION_H_
3030

31-
namespace v8 { namespace internal {
31+
namespace v8 {
32+
namespace internal {
3233

3334

3435
// A class that controls whether allocation is allowed. This is for

‎src/arguments.h‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@
2828
#ifndef V8_ARGUMENTS_H_
2929
#define V8_ARGUMENTS_H_
3030

31-
namespace v8 { namespace internal {
31+
namespace v8 {
32+
namespace internal {
3233

3334
// Arguments provides access to runtime call parameters.
3435
//

‎src/arm/assembler-arm-inl.h‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@
4141
#include "cpu.h"
4242

4343

44-
namespace v8 { namespace internal {
44+
namespace v8 {
45+
namespace internal {
4546

4647
Condition NegateCondition(Condition cc) {
4748
ASSERT(cc != al);

‎src/arm/assembler-arm.cc‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@
3939
#include "arm/assembler-arm-inl.h"
4040
#include "serialize.h"
4141

42-
namespace v8 { namespace internal {
42+
namespace v8 {
43+
namespace internal {
4344

4445
// -----------------------------------------------------------------------------
4546
// Implementation of Register and CRegister

‎src/arm/assembler-arm.h‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@
4242

4343
#include "assembler.h"
4444

45-
namespace v8 { namespace internal {
45+
namespace v8 {
46+
namespace internal {
4647

4748
// CPU Registers.
4849
//

‎src/arm/builtins-arm.cc‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@
3131
#include "debug.h"
3232
#include "runtime.h"
3333

34-
namespace v8 { namespace internal {
34+
namespace v8 {
35+
namespace internal {
3536

3637

3738
#define __ ACCESS_MASM(masm)

‎src/arm/codegen-arm.cc‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@
3636
#include "scopes.h"
3737

3838

39-
namespace v8 { namespace internal {
39+
namespace v8 {
40+
namespace internal {
4041

4142
#define __ ACCESS_MASM(masm_)
4243

0 commit comments

Comments
 (0)