[utils] Remove BoolToInt helper

backes · Commit Bot · commit 2a32d96bd243 · 2019-11-08T08:29:15.000Z
This function is trivial, can and be inlined to the single use. This makes utils.h a tiny little bit smaller. R=verwaest@chromium.org Bug: v8:9810, v8:8912 Change-Id: I877f3713530644a1cb9e0f286cf87f55072d33da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903444 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64850}
diff --git a/src/date/date.cc b/src/date/date.cc
@@ -128,8 +128,8 @@ void DateCache::YearMonthDayFromDays(int days, int* year, int* month,
   days += is_leap;
 
   // Check if the date is after February.
-  if (days >= 31 + 28 + BoolToInt(is_leap)) {
-    days -= 31 + 28 + BoolToInt(is_leap);
+  if (days >= 31 + 28 + (is_leap ? 1 : 0)) {
+    days -= 31 + 28 + (is_leap ? 1 : 0);
     // Find the date starting from March.
     for (int i = 2; i < 12; i++) {
       if (days < kDaysInMonths[i]) {
diff --git a/src/utils/utils.h b/src/utils/utils.h
@@ -53,8 +53,6 @@ inline char HexCharOfValue(int value) {
   return value - 10 + 'A';
 }
 
-inline int BoolToInt(bool b) { return b ? 1 : 0; }
-
 // Checks if value is in range [lower_limit, higher_limit] using a single
 // branch.
 template <typename T, typename U>

Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,6 @@ inline char HexCharOfValue(int value) {`
`53`	`53`	`return value - 10 + 'A';`
`54`	`54`	`}`
`55`	`55`
`56`		`-inline int BoolToInt(bool b) { return b ? 1 : 0; }`
`57`		`-`
`58`	`56`	`// Checks if value is in range [lower_limit, higher_limit] using a single`
`59`	`57`	`// branch.`
`60`	`58`	`template <typename T, typename U>`