Skip to content

Commit 1f72df0

Browse files
LeszekSwirskiCommit Bot
LeszekSwirski
authored and
Commit Bot
committed
[arm64/sim] Add a 'sim' gdb command
Extract out the command processing from Simulator::Debug(), and expose it to gdb as a new 'sim' command. Example usage: (gdb) sim p x15 (gdb) sim stack The sim command will execute that one command, and will return to gdb. For a list of all commands, you can call (gdb) sim help Note that sim won't resume simulator execution until gdb continues execution; for example, `sim next` will set a breakpoint on the next instruction, and will return to gdb. The user then has to continue execution in gdb, at which point the simulator will break. The user can then re-enter gdb with the gdb command. This will look like this: (gdb) sim next (gdb) continue ... sim> gdb (gdb) ... Change-Id: I678e71e2642d8427950b5f7ed65890ceae69e18d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2664448 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#72479}
1 parent 1f85cb1 commit 1f72df0

5 files changed

Lines changed: 328 additions & 271 deletions

File tree

‎src/diagnostics/objects-printer.cc‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2744,12 +2744,12 @@ V8_EXPORT_PRIVATE extern void _v8_internal_Print_Code(void* object) {
27442744
}
27452745

27462746
if (!isolate->heap()->InSpaceSlow(address, i::CODE_SPACE) &&
2747-
!isolate->heap()->InSpaceSlow(address, i::LO_SPACE) &&
2747+
!isolate->heap()->InSpaceSlow(address, i::CODE_LO_SPACE) &&
27482748
!i::InstructionStream::PcIsOffHeap(isolate, address) &&
27492749
!i::ReadOnlyHeap::Contains(address)) {
27502750
i::PrintF(
2751-
"%p is not within the current isolate's large object, code, read_only "
2752-
"or embedded spaces\n",
2751+
"%p is not within the current isolate's code, read_only or embedded "
2752+
"spaces\n",
27532753
object);
27542754
return;
27552755
}

0 commit comments

Comments
 (0)