Remove a few outdated TODO(yangguo)

hashseed · Commit Bot · commit 1daa4e440e3e · 2020-04-15T08:21:43.000Z
R=jgruber@chromium.org Bug: v8:6071 Change-Id: I346775e827fe9b2f24409dbba642c97622e9ea7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2149423 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#67143}
diff --git a/src/execution/isolate.cc b/src/execution/isolate.cc
@@ -1062,7 +1062,6 @@ Handle<Object> CaptureStackTrace(Isolate* isolate, Handle<Object> caller,
     }
   }
 
-  // TODO(yangguo): Queue this structured stack trace for preprocessing on GC.
   return builder.GetElementsAsStackTraceFrameArray();
 }
 
diff --git a/src/handles/handles.h b/src/handles/handles.h
@@ -148,7 +148,7 @@ class Handle final : public HandleBase {
   template <typename S>
   inline static const Handle<T> cast(Handle<S> that);
 
-  // TODO(yangguo): Values that contain empty handles should be declared as
+  // Consider declaring values that contain empty handles as
   // MaybeHandle to force validation before being used as handles.
   static const Handle<T> null() { return Handle<T>(); }
 
diff --git a/src/parsing/parse-info.cc b/src/parsing/parse-info.cc
@@ -93,8 +93,6 @@ ParseInfo::ParseInfo(Isolate* isolate, SharedFunctionInfo shared)
     : ParseInfo(isolate, isolate->allocator(),
                 Script::cast(shared.script()).id()) {
   // Do not support re-parsing top-level function of a wrapped script.
-  // TODO(yangguo): consider whether we need a top-level function in a
-  //                wrapped script at all.
   DCHECK_IMPLIES(is_toplevel(), !Script::cast(shared.script()).is_wrapped());
 
   set_allow_lazy_parsing(true);
diff --git a/src/runtime/runtime-regexp.cc b/src/runtime/runtime-regexp.cc
@@ -1234,7 +1234,6 @@ static Object SearchRegExpMultiple(Isolate* isolate, Handle<String> subject,
 
     if (subject_length > kMinLengthToCache) {
       // Store the last successful match into the array for caching.
-      // TODO(yangguo): do not expose last match to JS and simplify caching.
       int capture_registers = (capture_count + 1) * 2;
       Handle<FixedArray> last_match_cache =
           isolate->factory()->NewFixedArray(capture_registers);
diff --git a/test/message/message.status b/test/message/message.status
@@ -44,8 +44,8 @@
 }], # arch != x64 and arch != ia32 and arch != arm64 and arch != arm
 
 ['variant == code_serializer', {
-  # TODO(yangguo): Code serializer output is incompatible with all message
-  # tests.
+  # Code serializer output is incompatible with all message tests
+  # because the same test is executed twice.
   '*': [SKIP],
 }],  # variant == code_serializer
 

Original file line number	Diff line number	Diff line change
`@@ -1062,7 +1062,6 @@ Handle<Object> CaptureStackTrace(Isolate* isolate, Handle<Object> caller,`
`1062`	`1062`	`}`
`1063`	`1063`	`}`
`1064`	`1064`
`1065`		`- // TODO(yangguo): Queue this structured stack trace for preprocessing on GC.`
`1066`	`1065`	`return builder.GetElementsAsStackTraceFrameArray();`
`1067`	`1066`	`}`
`1068`	`1067`