[wasm][debug] Switch one more test to Liftoff debugging

backes · Commit Bot · commit 12e3c8462efc · 2020-03-27T16:21:52.000Z
The output extends by four more breaks, since when stepping out of the function that has the breakpoint, we now also step through the two other functions on the stack. R=thibaudm@chromium.org Bug: v8:10351 Change-Id: I4b042cad0d88b923c3894fe979c43837260eb958 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2124315 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#66892}
diff --git a/test/inspector/debugger/wasm-scope-info-liftoff-expected.txt b/test/inspector/debugger/wasm-scope-info-liftoff-expected.txt
@@ -161,6 +161,86 @@ at (anonymous) (0:17):
  - scope (global):
    -- skipped globals
 
+Paused:
+Script wasm://wasm/c4eb034a byte offset 78: Wasm opcode 0x1a
+Scope:
+at B (liftoff) (0:78):
+ - scope (global):
+   globals: "global0": 42 (number)
+ - scope (local):
+   locals: "0": 0 (number), "i32_arg": 42 (number), "i32_local": 0 (number), "f32_local": 7.199999809265137 (number), "var5": 0 (number)
+   stack: "0": 42 (number), "1": 3 (number)
+ - scope (wasm-expression-stack):
+   0: 42 (number)
+   1: 3 (number)
+at A (liftoff) (0:54):
+ - scope (global):
+   globals: "global0": 42 (number)
+ - scope (local):
+   locals: "var0": 42 (number)
+   stack: 
+ - scope (wasm-expression-stack):
+at (anonymous) (0:17):
+ - scope (global):
+   -- skipped globals
+
+Paused:
+Script wasm://wasm/c4eb034a byte offset 79: Wasm opcode 0x1a
+Scope:
+at B (liftoff) (0:79):
+ - scope (global):
+   globals: "global0": 42 (number)
+ - scope (local):
+   locals: "0": 0 (number), "i32_arg": 42 (number), "i32_local": 0 (number), "f32_local": 7.199999809265137 (number), "var5": 0 (number)
+   stack: "0": 42 (number)
+ - scope (wasm-expression-stack):
+   0: 42 (number)
+at A (liftoff) (0:54):
+ - scope (global):
+   globals: "global0": 42 (number)
+ - scope (local):
+   locals: "var0": 42 (number)
+   stack: 
+ - scope (wasm-expression-stack):
+at (anonymous) (0:17):
+ - scope (global):
+   -- skipped globals
+
+Paused:
+Script wasm://wasm/c4eb034a byte offset 80: Wasm opcode 0x0b
+Scope:
+at B (liftoff) (0:80):
+ - scope (global):
+   globals: "global0": 42 (number)
+ - scope (local):
+   locals: "0": 0 (number), "i32_arg": 42 (number), "i32_local": 0 (number), "f32_local": 7.199999809265137 (number), "var5": 0 (number)
+   stack: 
+ - scope (wasm-expression-stack):
+at A (liftoff) (0:54):
+ - scope (global):
+   globals: "global0": 42 (number)
+ - scope (local):
+   locals: "var0": 42 (number)
+   stack: 
+ - scope (wasm-expression-stack):
+at (anonymous) (0:17):
+ - scope (global):
+   -- skipped globals
+
+Paused:
+Script wasm://wasm/c4eb034a byte offset 56: Wasm opcode 0x0b
+Scope:
+at A (liftoff) (0:56):
+ - scope (global):
+   globals: "global0": 42 (number)
+ - scope (local):
+   locals: "var0": 42 (number)
+   stack: 
+ - scope (wasm-expression-stack):
+at (anonymous) (0:17):
+ - scope (global):
+   -- skipped globals
+
 Paused:
 instance.exports.main(42)#
 
diff --git a/test/inspector/debugger/wasm-scope-info-liftoff.js b/test/inspector/debugger/wasm-scope-info-liftoff.js
@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// Flags: --debug-in-liftoff
+
 let {session, contextGroup, Protocol} = InspectorTest.start(
     'Test retrieving scope information from compiled Liftoff frames');
 session.setupScriptMap();
diff --git a/test/inspector/inspector.status b/test/inspector/inspector.status
@@ -23,7 +23,6 @@
   # differences to the old behaviour (in particular, anyref is not
   # implemented in Liftoff yet).
   # TODO(clemensb/thibaudm): Get this list to zero and remove this block.
-  'debugger/wasm-scope-info-liftoff': [FAIL],
   'debugger/wasm-stepping-in-from-js': [FAIL],
   'debugger/wasm-anyref-global': [FAIL],
 }],
