Skip to content

Commit 0999cfb

Browse files
fserbCommit Bot
authored andcommitted
Add adjust_os_scheduling_parameters flag for v8 isolate
This will allow the test infrastructure to bypass isolate scheduling restrictions. Bug: chromium:1002582 Change-Id: Ib22a599cf6c826c3d412898520dba6f4045175b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801995 Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#63811}
1 parent 0aac347 commit 0999cfb

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

src/execution/isolate.cc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,9 @@ Isolate::FindOrAllocatePerThreadDataForThisThread() {
320320
base::MutexGuard lock_guard(&thread_data_table_mutex_);
321321
per_thread = thread_data_table_.Lookup(thread_id);
322322
if (per_thread == nullptr) {
323-
base::OS::AdjustSchedulingParams();
323+
if (FLAG_adjust_os_scheduling_parameters) {
324+
base::OS::AdjustSchedulingParams();
325+
}
324326
per_thread = new PerIsolateThreadData(this, thread_id);
325327
thread_data_table_.Insert(per_thread);
326328
}

src/flags/flag-definitions.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1238,6 +1238,8 @@ DEFINE_BOOL(print_all_exceptions, false,
12381238
DEFINE_BOOL(
12391239
detailed_error_stack_trace, false,
12401240
"includes arguments for each function call in the error stack frames array")
1241+
DEFINE_BOOL(adjust_os_scheduling_parameters, true,
1242+
"adjust OS specific scheduling params for the isolate")
12411243

12421244
// runtime.cc
12431245
DEFINE_BOOL(runtime_call_stats, false, "report runtime call counts and times")

0 commit comments

Comments
 (0)