Skip to content

Commit 07a0f9e

Browse files
hashseedCommit bot
authored andcommitted
[debugger] be more lenient about argument type in %DebugGetProperty.
R=mstarzinger@chromium.org BUG=chromium:629996 Review-Url: https://codereview.chromium.org/2166123003 Cr-Commit-Position: refs/heads/master@{#37942}
1 parent f04fd63 commit 07a0f9e

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

src/runtime/runtime-debug.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,7 @@ RUNTIME_FUNCTION(Runtime_DebugGetProperty) {
408408

409409
DCHECK(args.length() == 2);
410410

411-
CONVERT_ARG_HANDLE_CHECKED(JSObject, obj, 0);
411+
CONVERT_ARG_HANDLE_CHECKED(Object, obj, 0);
412412
CONVERT_ARG_HANDLE_CHECKED(Name, name, 1);
413413

414414
LookupIterator it(obj, name);
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
// Copyright 2016 the V8 project authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
// // Flags: --expose-debug-as debug
6+
7+
var mirror = debug.MakeMirror(new Proxy({}, {}));
8+
// As long as we have no special mirror for proxies, we use an object mirror.
9+
assertEquals("object", mirror.type());

0 commit comments

Comments
 (0)